[PR #2891] [MERGED] Add conformance test for glue reuse issue #3402

New issue

Closed

opened 2026-03-16 11:41:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:41:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2891
Author: @divergentdave
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/28/2025
Merged by: @divergentdave

Base: main ← Head: david/conformance-test-glue-reuse

📝 Commits (2)

985b72e Add builder for name server, allow overriding FQDN
b5fa9ad Add conformance test for glue reuse issue

📊 Changes

2 files changed (+117 additions, -23 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+44 -0)
📝 conformance/packages/dns-test/src/name_server.rs (+73 -23)

📄 Description

This adds a builder for NameServer, and then uses it to add a reproducer for the ideleg.net. IN A issue mentioned in https://github.com/hickory-dns/hickory-dns/issues/2602#issuecomment-2761406086.

In this test, the zone hickory-dns.testing. is served by a nameserver hosted at hickory-dns.testing., and thus the zone file for testing. includes a hickory-dns.testing. IN A glue record. Then, querying for hickory-dns.testing. IN A demonstrates the problem, because the glue data is reused, and a SERVFAIL response is returned for a lack of RRSIG records.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2891 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/28/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/conformance-test-glue-reuse` --- ### 📝 Commits (2) - [`985b72e`](https://github.com/hickory-dns/hickory-dns/commit/985b72ea507f52ca745632129ee7ccf95df1aa98) Add builder for name server, allow overriding FQDN - [`b5fa9ad`](https://github.com/hickory-dns/hickory-dns/commit/b5fa9adad9129dacd1b3621e17def435ba3b30c7) Add conformance test for glue reuse issue ### 📊 Changes **2 files changed** (+117 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+44 -0) 📝 `conformance/packages/dns-test/src/name_server.rs` (+73 -23) </details> ### 📄 Description This adds a builder for `NameServer`, and then uses it to add a reproducer for the `ideleg.net. IN A` issue mentioned in https://github.com/hickory-dns/hickory-dns/issues/2602#issuecomment-2761406086. In this test, the zone `hickory-dns.testing.` is served by a nameserver hosted at `hickory-dns.testing.`, and thus the zone file for `testing.` includes a `hickory-dns.testing. IN A` glue record. Then, querying for `hickory-dns.testing. IN A` demonstrates the problem, because the glue data is reused, and a SERVFAIL response is returned for a lack of RRSIG records. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>