[PR #3397] [MERGED] resolver: replace RecursorBuilder with RecursiveConfig #3807

New issue

Closed

opened 2026-03-16 12:03:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:03:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3397
Author: @djc
Created: 12/13/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @djc

Base: main ← Head: recursive-config

📝 Commits (10+)

dba4613 resolver: untangle transport state setup from builder
5f7c6b8 resolver: copy builder defaults to RecursiveConfig
2450cbe recursor: stop supporting unlimited recursion
1bffd11 resolver: inline single-caller function
4981245 resolver: don't move connection provider through RecursorBuilder
6f37187 resolver: introduce intermediate RecursorOptions type
bb5b9e5 resolver: drop most of the recursor builder API
ae8d2c7 resolver: drop the remainder of the recursor builder API
3fbf82b resolver: move DnssecPolicyConfig::load() to DnssecPolicy::from_config()
3197264 resolver: move persistent state reading into OpportunisticEncryption method

📊 Changes

7 files changed (+411 additions, -509 deletions)

View changed files

📝 crates/resolver/src/config.rs (+67 -1)
📝 crates/resolver/src/recursor/error.rs (+3 -4)
📝 crates/resolver/src/recursor/handle.rs (+59 -36)
📝 crates/resolver/src/recursor/mod.rs (+195 -428)
📝 crates/resolver/src/recursor/tests.rs (+76 -37)
📝 crates/server/src/store/recursor.rs (+4 -1)
📝 util/src/bin/recurse.rs (+7 -2)

📄 Description

As suggested in:

#3387

This was all a bit tangled up so the commits are somewhat circuitous, but I think this makes for a nice simplification in the end.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3397 **Author:** [@djc](https://github.com/djc) **Created:** 12/13/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `recursive-config` --- ### 📝 Commits (10+) - [`dba4613`](https://github.com/hickory-dns/hickory-dns/commit/dba4613e47fc72c5af62b96f79657d28773117f1) resolver: untangle transport state setup from builder - [`5f7c6b8`](https://github.com/hickory-dns/hickory-dns/commit/5f7c6b88793f5c137b61a9eb17c2e9fa208441b5) resolver: copy builder defaults to RecursiveConfig - [`2450cbe`](https://github.com/hickory-dns/hickory-dns/commit/2450cbe325a2a31b26eec7a31bc694f91333d69b) recursor: stop supporting unlimited recursion - [`1bffd11`](https://github.com/hickory-dns/hickory-dns/commit/1bffd1129157a7b5fa12fba51b78d1c13d641248) resolver: inline single-caller function - [`4981245`](https://github.com/hickory-dns/hickory-dns/commit/4981245f3ce92992ac9958601d367a970941ffa3) resolver: don't move connection provider through RecursorBuilder - [`6f37187`](https://github.com/hickory-dns/hickory-dns/commit/6f371873809311aa0f331a557ab56d979457633a) resolver: introduce intermediate RecursorOptions type - [`bb5b9e5`](https://github.com/hickory-dns/hickory-dns/commit/bb5b9e57729ac100ff25779e883a4ba6ed1f167f) resolver: drop most of the recursor builder API - [`ae8d2c7`](https://github.com/hickory-dns/hickory-dns/commit/ae8d2c72f43b529983f7b482a70ec70f763d2eb1) resolver: drop the remainder of the recursor builder API - [`3fbf82b`](https://github.com/hickory-dns/hickory-dns/commit/3fbf82b84169ed1e4a66adb9c30281ce1c9d9121) resolver: move DnssecPolicyConfig::load() to DnssecPolicy::from_config() - [`3197264`](https://github.com/hickory-dns/hickory-dns/commit/31972647931512a083917caf7858e96b38b2d201) resolver: move persistent state reading into OpportunisticEncryption method ### 📊 Changes **7 files changed** (+411 additions, -509 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/config.rs` (+67 -1) 📝 `crates/resolver/src/recursor/error.rs` (+3 -4) 📝 `crates/resolver/src/recursor/handle.rs` (+59 -36) 📝 `crates/resolver/src/recursor/mod.rs` (+195 -428) 📝 `crates/resolver/src/recursor/tests.rs` (+76 -37) 📝 `crates/server/src/store/recursor.rs` (+4 -1) 📝 `util/src/bin/recurse.rs` (+7 -2) </details> ### 📄 Description As suggested in: - #3387 This was all a bit tangled up so the commits are somewhat circuitous, but I think this makes for a nice simplification in the end. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>