[PR #2884] [CLOSED] Expand wildcard labels into any number of labels #3397

Closed
opened 2026-03-16 11:41:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2884
Author: @divergentdave
Created: 3/24/2025
Status: Closed

Base: mainHead: david/wildcard-expansion


📝 Commits (2)

  • cf958c2 Expand wildcard labels into any number of labels
  • 42ebc46 Add tests of wildcard expansion

📊 Changes

3 files changed (+124 additions, -33 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+38 -0)
📝 bin/tests/integration/authority_battery/dnssec.rs (+38 -0)
📝 crates/server/src/store/in_memory/authority.rs (+48 -33)

📄 Description

This tweaks the authoritative server to look for any applicable wildcard record, rather than only replacing the leftmost label with *.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2884 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/wildcard-expansion` --- ### 📝 Commits (2) - [`cf958c2`](https://github.com/hickory-dns/hickory-dns/commit/cf958c2ec568811de459f66f1264edadeb02bc7f) Expand wildcard labels into any number of labels - [`42ebc46`](https://github.com/hickory-dns/hickory-dns/commit/42ebc467d2731b3c87823672cf627f4cf91dff4a) Add tests of wildcard expansion ### 📊 Changes **3 files changed** (+124 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+38 -0) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+38 -0) 📝 `crates/server/src/store/in_memory/authority.rs` (+48 -33) </details> ### 📄 Description This tweaks the authoritative server to look for any applicable wildcard record, rather than only replacing the leftmost label with `*`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:41:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3397
No description provided.