[PR #3355] [MERGED] Opportunistic encryption integration test #3771

New issue

Closed

opened 2026-03-16 12:01:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3355
Author: @divergentdave
Created: 11/20/2025
Status: ✅ Merged
Merged: 11/20/2025
Merged by: @divergentdave

Base: main ← Head: david/opp-enc-integration-test

📝 Commits (3)

5d63804 Fix handling of relative path for state file
3eaa9ce Only fsync directories on Unix family targets
8586e06 Add RFC 9539 binary integration test

📊 Changes

4 files changed (+50 additions, -5 deletions)

View changed files

📝 bin/tests/integration/main.rs (+2 -0)
➕ bin/tests/integration/named_rfc_9539_tests.rs (+29 -0)
📝 crates/resolver/src/name_server_pool.rs (+18 -4)
📝 tests/test-data/test_configs/example_recursor_opportunistic_enc.toml (+1 -1)

📄 Description

This adds a binary integration test with the opportunistic encryption config file. Along the way, I fixed an issue with one-component relative paths and fixed Windows support by skipping the directory sync_all() call. (On Windows, this returns a permission error, and it looks like there isn't any equivalent API to sync a directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3355 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/20/2025 **Status:** ✅ Merged **Merged:** 11/20/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/opp-enc-integration-test` --- ### 📝 Commits (3) - [`5d63804`](https://github.com/hickory-dns/hickory-dns/commit/5d63804d124c8e658bc0109a3b53e1962b7ea889) Fix handling of relative path for state file - [`3eaa9ce`](https://github.com/hickory-dns/hickory-dns/commit/3eaa9ce99ea60ab1971169edeabd4fe9c4acb46b) Only fsync directories on Unix family targets - [`8586e06`](https://github.com/hickory-dns/hickory-dns/commit/8586e06c15a22b1bb96413a17fa329bdc609f417) Add RFC 9539 binary integration test ### 📊 Changes **4 files changed** (+50 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/main.rs` (+2 -0) ➕ `bin/tests/integration/named_rfc_9539_tests.rs` (+29 -0) 📝 `crates/resolver/src/name_server_pool.rs` (+18 -4) 📝 `tests/test-data/test_configs/example_recursor_opportunistic_enc.toml` (+1 -1) </details> ### 📄 Description This adds a binary integration test with the opportunistic encryption config file. Along the way, I fixed an issue with one-component relative paths and fixed Windows support by skipping the directory `sync_all()` call. (On Windows, this returns a permission error, and it looks like there isn't any equivalent API to sync a directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>