[PR #2840] [MERGED] Trust anchors tweaks #3355

New issue

Closed

opened 2026-03-16 11:39:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:39:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2840
Author: @djc
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @djc

Base: main ← Head: trust-anchors

📝 Commits (10+)

834a55f proto: move Default impl below inherent impl
3389b51 proto: rename TrustAnchor::new() to empty()
bf8b3bf proto: externalize potential panic in TrustAnchor::get()
fd20399 proto: rename TrustAnchor to TrustAnchors
d2c988b proto: make TrustAnchors::insert() more like HashSet::insert()
cac1472 proto: move TrustAnchors::read_from_file() constructor up
44adbc6 proto: rename TrustAnchors::read_from_file() to from_file()
8996f5a proto: simplify TrustAnchors interface
771907e proto: avoid abstractions in TrustAnchors parser code
770ed46 proto: use ParseError directly for TrustAnchors parsing

📊 Changes

15 files changed (+99 additions, -104 deletions)

View changed files

📝 bin/tests/integration/named_test_rsa_dnssec.rs (+4 -4)
📝 crates/client/src/client/dnssec_client.rs (+4 -4)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+6 -9)
📝 crates/proto/src/dnssec/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/trust_anchor.rs (+54 -55)
📝 crates/recursor/src/lib.rs (+2 -2)
📝 crates/recursor/src/recursor.rs (+2 -2)
📝 crates/resolver/src/resolver.rs (+5 -4)
📝 crates/server/src/store/forwarder/authority.rs (+4 -4)
📝 crates/server/src/store/recursor/authority.rs (+1 -1)
📝 crates/server/src/store/recursor/config.rs (+4 -3)
📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+3 -3)
📝 tests/integration-tests/tests/integration/invalid_nsec3_tests.rs (+3 -3)
📝 tests/integration-tests/tests/integration/validating_forwarder_tests.rs (+3 -3)
📝 util/src/bin/dns.rs (+3 -6)

📄 Description

Followup from #2838.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2840 **Author:** [@djc](https://github.com/djc) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `trust-anchors` --- ### 📝 Commits (10+) - [`834a55f`](https://github.com/hickory-dns/hickory-dns/commit/834a55f9a7a3af3a79dd260f5c68d66b49544dcf) proto: move Default impl below inherent impl - [`3389b51`](https://github.com/hickory-dns/hickory-dns/commit/3389b51f556ee2d658629c40c7cac83ab7f0a52e) proto: rename TrustAnchor::new() to empty() - [`bf8b3bf`](https://github.com/hickory-dns/hickory-dns/commit/bf8b3bf57bfb80f6ebd751230916125de6a5b6f3) proto: externalize potential panic in TrustAnchor::get() - [`fd20399`](https://github.com/hickory-dns/hickory-dns/commit/fd20399bce7ef2a3d06e02587a486460e23deb43) proto: rename TrustAnchor to TrustAnchors - [`d2c988b`](https://github.com/hickory-dns/hickory-dns/commit/d2c988b9f9e247ed9aac8cb750bd5c7dd6c7e892) proto: make TrustAnchors::insert() more like HashSet::insert() - [`cac1472`](https://github.com/hickory-dns/hickory-dns/commit/cac147291b51dbb502254e9bd17152d2770deef6) proto: move TrustAnchors::read_from_file() constructor up - [`44adbc6`](https://github.com/hickory-dns/hickory-dns/commit/44adbc60c364f32e6c81cabc12bf3e56e89f757a) proto: rename TrustAnchors::read_from_file() to from_file() - [`8996f5a`](https://github.com/hickory-dns/hickory-dns/commit/8996f5ad78092946286d3ff053ba7aa3665a5a88) proto: simplify TrustAnchors interface - [`771907e`](https://github.com/hickory-dns/hickory-dns/commit/771907e99af683845bda17f54c0e04201561aa8e) proto: avoid abstractions in TrustAnchors parser code - [`770ed46`](https://github.com/hickory-dns/hickory-dns/commit/770ed46132099cf8c6bd32b6d96a91641e88582a) proto: use ParseError directly for TrustAnchors parsing ### 📊 Changes **15 files changed** (+99 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+4 -4) 📝 `crates/client/src/client/dnssec_client.rs` (+4 -4) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+6 -9) 📝 `crates/proto/src/dnssec/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/trust_anchor.rs` (+54 -55) 📝 `crates/recursor/src/lib.rs` (+2 -2) 📝 `crates/recursor/src/recursor.rs` (+2 -2) 📝 `crates/resolver/src/resolver.rs` (+5 -4) 📝 `crates/server/src/store/forwarder/authority.rs` (+4 -4) 📝 `crates/server/src/store/recursor/authority.rs` (+1 -1) 📝 `crates/server/src/store/recursor/config.rs` (+4 -3) 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+3 -3) 📝 `tests/integration-tests/tests/integration/invalid_nsec3_tests.rs` (+3 -3) 📝 `tests/integration-tests/tests/integration/validating_forwarder_tests.rs` (+3 -3) 📝 `util/src/bin/dns.rs` (+3 -6) </details> ### 📄 Description Followup from #2838. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>