[PR #3354] [MERGED] HTTP headers tweaks #3766

Closed
opened 2026-03-16 12:01:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3354
Author: @djc
Created: 11/18/2025
Status: Merged
Merged: 11/19/2025
Merged by: @djc

Base: mainHead: http-headers-tweaks


📝 Commits (9)

  • 3daad16 resolver: store TLS client config directly into PoolContext
  • 06fcb3c proto: move AddHeaders trait to http module
  • 52aa3a6 proto: rename additional_headers to add_headers
  • b93ed7e proto: move manual state machine to async
  • 1817029 proto: fold h2 server items into h2 module
  • 50b70e3 proto: extend AddHeaders support to H3
  • 67fce6a proto: extract RequestContext helper
  • a07b5c4 proto: allow trait to mutate header map
  • c817e28 proto: rename name_server_name to server_name

📊 Changes

11 files changed (+393 additions, -548 deletions)

View changed files

📝 crates/proto/src/h2/h2_client_stream.rs (+90 -268)
crates/proto/src/h2/h2_server.rs (+0 -153)
📝 crates/proto/src/h2/mod.rs (+152 -5)
📝 crates/proto/src/h3/h3_client_stream.rs (+26 -19)
📝 crates/proto/src/http/mod.rs (+11 -0)
📝 crates/proto/src/http/request.rs (+90 -89)
📝 crates/proto/src/xfer/dns_exchange.rs (+1 -1)
📝 crates/resolver/src/connection_provider.rs (+5 -4)
📝 crates/resolver/src/name_server_pool.rs (+5 -2)
📝 crates/resolver/src/resolver.rs (+10 -4)
📝 crates/server/src/server/h2_handler.rs (+3 -3)

📄 Description

A bunch of followup from

cc @lpraneis


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3354 **Author:** [@djc](https://github.com/djc) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/19/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `http-headers-tweaks` --- ### 📝 Commits (9) - [`3daad16`](https://github.com/hickory-dns/hickory-dns/commit/3daad161858c2b6acaa4a9aa7f34fd9af60f5b44) resolver: store TLS client config directly into PoolContext - [`06fcb3c`](https://github.com/hickory-dns/hickory-dns/commit/06fcb3c8dbf21362e1f9e7e749ef51ee12481870) proto: move AddHeaders trait to http module - [`52aa3a6`](https://github.com/hickory-dns/hickory-dns/commit/52aa3a67d816e68cf8ce80a61202f0ecc191ee67) proto: rename additional_headers to add_headers - [`b93ed7e`](https://github.com/hickory-dns/hickory-dns/commit/b93ed7efb97aef6ce4bbd26a6f2e81455a2a7c84) proto: move manual state machine to async - [`1817029`](https://github.com/hickory-dns/hickory-dns/commit/18170293f1bf2e4607998aa089cb8f4014ae6bd1) proto: fold h2 server items into h2 module - [`50b70e3`](https://github.com/hickory-dns/hickory-dns/commit/50b70e3c83fa0d4276bfee868f8dea1a452e960b) proto: extend AddHeaders support to H3 - [`67fce6a`](https://github.com/hickory-dns/hickory-dns/commit/67fce6a7208722f5023925cd3940287b43733dc8) proto: extract RequestContext helper - [`a07b5c4`](https://github.com/hickory-dns/hickory-dns/commit/a07b5c40367e81b3adff545848d8442ff697ad1e) proto: allow trait to mutate header map - [`c817e28`](https://github.com/hickory-dns/hickory-dns/commit/c817e2833a59b85efac2421add014c45818ada4b) proto: rename name_server_name to server_name ### 📊 Changes **11 files changed** (+393 additions, -548 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/h2/h2_client_stream.rs` (+90 -268) ➖ `crates/proto/src/h2/h2_server.rs` (+0 -153) 📝 `crates/proto/src/h2/mod.rs` (+152 -5) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+26 -19) 📝 `crates/proto/src/http/mod.rs` (+11 -0) 📝 `crates/proto/src/http/request.rs` (+90 -89) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+1 -1) 📝 `crates/resolver/src/connection_provider.rs` (+5 -4) 📝 `crates/resolver/src/name_server_pool.rs` (+5 -2) 📝 `crates/resolver/src/resolver.rs` (+10 -4) 📝 `crates/server/src/server/h2_handler.rs` (+3 -3) </details> ### 📄 Description A bunch of followup from - #3347 cc @lpraneis --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 12:01:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3766
No description provided.