for Protocol enum #3354

New issue

Closed

opened 2026-03-16 11:39:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:39:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2832
Author: @LVivona
Created: 3/5/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

7577fb9 feat(core): implement From and From for Protocol enum

📊 Changes

1 file changed (+39 additions, -0 deletions)

View changed files

📝 crates/proto/src/xfer/mod.rs (+39 -0)

📄 Description

Summary

While working on pull request for libp2p, I noticed that Protocol couldn't be converted using Into, so I implemented the From trait to make conversions more convenient.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2832 **Author:** [@LVivona](https://github.com/LVivona) **Created:** 3/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`7577fb9`](https://github.com/hickory-dns/hickory-dns/commit/7577fb99c922c8069ac6ae9cd852bdf056970284) feat(core): implement From<u8> and From<Protocol> for Protocol enum ### 📊 Changes **1 file changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/mod.rs` (+39 -0) </details> ### 📄 Description ### Summary While working on pull request for libp2p, I noticed that Protocol couldn't be converted using Into, so I implemented the From trait to make conversions more convenient. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>