[PR #3261] [MERGED] Replace dnslib #3690

Closed
opened 2026-03-16 11:57:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3261
Author: @marcus0x62
Created: 9/4/2025
Status: Merged
Merged: 9/17/2025
Merged by: @marcus0x62

Base: mainHead: replace_dnslib


📝 Commits (10+)

  • 135dffd add rust-based dns test-server
  • dffd8da dns-test changes for TestServer
  • 03ecf3e migrate bad txid test to TestServer
  • 8afeadb migrate empty_response tests to TestServer
  • abf2b37 migrate truncated response test to TestServer
  • 8756a45 migrate packet loss test to TestServer
  • cde0a13 migrate bad case tests to TestServer
  • 2c02d74 migrate cname loop test to TestServer
  • ff698b8 proto: add method to create RRSIG record from SIG data
  • 56186ca migrate nsec3 does_not_cover test to TestServer

📊 Changes

30 files changed (+2184 additions, -681 deletions)

View changed files

📝 conformance/Cargo.lock (+874 -3)
📝 conformance/Cargo.toml (+1 -1)
📝 conformance/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs (+20 -12)
conformance/conformance-tests/src/resolver/dns/rfc1035/truncated_udp_only.py (+0 -36)
conformance/conformance-tests/src/resolver/dns/rfc1035/truncated_with_tcp_fallback.py (+0 -46)
📝 conformance/conformance-tests/src/resolver/dns/rfc1035/truncation.rs (+9 -8)
conformance/conformance-tests/src/resolver/dns/scenarios/empty_response.py (+0 -15)
📝 conformance/conformance-tests/src/resolver/dns/scenarios/no_soa.rs (+5 -5)
conformance/conformance-tests/src/resolver/dns/scenarios/packet_loss.py (+0 -38)
📝 conformance/conformance-tests/src/resolver/dns/scenarios/packet_loss.rs (+6 -4)
📝 conformance/conformance-tests/src/resolver/dnssec/scenarios/no_soa.rs (+5 -5)
📝 conformance/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs (+32 -14)
conformance/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/server.py (+0 -277)
📝 conformance/dns-test/src/container.rs (+87 -18)
conformance/dns-test/src/docker/dnslib.Dockerfile (+0 -9)
conformance/dns-test/src/docker/test-server.Dockerfile (+30 -0)
📝 conformance/dns-test/src/implementation.rs (+43 -28)
📝 conformance/dns-test/src/name_server.rs (+5 -21)
📝 conformance/dns-test/src/resolver.rs (+1 -0)
conformance/e2e-tests/src/recursor/cname/cname_loop.py (+0 -28)

...and 10 more files

📄 Description

This replaces the Python-based dnslib server with a simple Rust-based server that supports RFC 1035 UDP and TCP messages.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3261 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `replace_dnslib` --- ### 📝 Commits (10+) - [`135dffd`](https://github.com/hickory-dns/hickory-dns/commit/135dffde8bb022acd0a4ae26bcc3bfe9cf6a37cc) add rust-based dns test-server - [`dffd8da`](https://github.com/hickory-dns/hickory-dns/commit/dffd8da60f0d4cdf4504554d052ed20a0fa8fc4d) dns-test changes for TestServer - [`03ecf3e`](https://github.com/hickory-dns/hickory-dns/commit/03ecf3e9b6b03ce32aa38cdceb62c606ba19e4a5) migrate bad txid test to TestServer - [`8afeadb`](https://github.com/hickory-dns/hickory-dns/commit/8afeadb3879073a2dcb6ec0fd1a03934864c9671) migrate empty_response tests to TestServer - [`abf2b37`](https://github.com/hickory-dns/hickory-dns/commit/abf2b37a7fa64c5aa08199da54e9de81234fae23) migrate truncated response test to TestServer - [`8756a45`](https://github.com/hickory-dns/hickory-dns/commit/8756a45d95ffa6f671fc799edc81eae9af3cf147) migrate packet loss test to TestServer - [`cde0a13`](https://github.com/hickory-dns/hickory-dns/commit/cde0a135913114d47d2caccb19b7cfa02f26bb8c) migrate bad case tests to TestServer - [`2c02d74`](https://github.com/hickory-dns/hickory-dns/commit/2c02d7437ccd7be5f304af505bab1ffdfe527d15) migrate cname loop test to TestServer - [`ff698b8`](https://github.com/hickory-dns/hickory-dns/commit/ff698b81b2ad7507dc676605d4966ba232e234d6) proto: add method to create RRSIG record from SIG data - [`56186ca`](https://github.com/hickory-dns/hickory-dns/commit/56186ca7a4d897ab228a24e8e2fe691f3cb9b799) migrate nsec3 does_not_cover test to TestServer ### 📊 Changes **30 files changed** (+2184 additions, -681 deletions) <details> <summary>View changed files</summary> 📝 `conformance/Cargo.lock` (+874 -3) 📝 `conformance/Cargo.toml` (+1 -1) 📝 `conformance/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs` (+20 -12) ➖ `conformance/conformance-tests/src/resolver/dns/rfc1035/truncated_udp_only.py` (+0 -36) ➖ `conformance/conformance-tests/src/resolver/dns/rfc1035/truncated_with_tcp_fallback.py` (+0 -46) 📝 `conformance/conformance-tests/src/resolver/dns/rfc1035/truncation.rs` (+9 -8) ➖ `conformance/conformance-tests/src/resolver/dns/scenarios/empty_response.py` (+0 -15) 📝 `conformance/conformance-tests/src/resolver/dns/scenarios/no_soa.rs` (+5 -5) ➖ `conformance/conformance-tests/src/resolver/dns/scenarios/packet_loss.py` (+0 -38) 📝 `conformance/conformance-tests/src/resolver/dns/scenarios/packet_loss.rs` (+6 -4) 📝 `conformance/conformance-tests/src/resolver/dnssec/scenarios/no_soa.rs` (+5 -5) 📝 `conformance/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs` (+32 -14) ➖ `conformance/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/server.py` (+0 -277) 📝 `conformance/dns-test/src/container.rs` (+87 -18) ➖ `conformance/dns-test/src/docker/dnslib.Dockerfile` (+0 -9) ➕ `conformance/dns-test/src/docker/test-server.Dockerfile` (+30 -0) 📝 `conformance/dns-test/src/implementation.rs` (+43 -28) 📝 `conformance/dns-test/src/name_server.rs` (+5 -21) 📝 `conformance/dns-test/src/resolver.rs` (+1 -0) ➖ `conformance/e2e-tests/src/recursor/cname/cname_loop.py` (+0 -28) _...and 10 more files_ </details> ### 📄 Description This replaces the Python-based dnslib server with a simple Rust-based server that supports RFC 1035 UDP and TCP messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:57:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3690
No description provided.