[PR #2711] [MERGED] Add ede-dot-com tests that don't rely on internet name servers #3261

New issue

Closed

opened 2026-03-16 11:34:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:34:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2711
Author: @divergentdave
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @divergentdave

Base: main ← Head: david/docker-ede

📝 Commits (7)

7f71bfc ede-dot-com: ignore failing test
0e21dda ede-dot-com: reconcile list of subdomains
f14a978 ede-dot-com: unignore passing tests
9860cef ede-dot-com: add tests using Docker network
ebd23c1 ede-dot-com: only generate one child zone per test
f858555 ci: run ede-dot-com tests that don't use internet
993bf0e ede-dot-com: add reasons to ignore attributes

📊 Changes

11 files changed (+1130 additions, -103 deletions)

View changed files

📝 .github/workflows/conformance.yml (+3 -0)
📝 conformance/packages/dns-test/src/container.rs (+22 -0)
➕ conformance/packages/dns-test/src/docker/ede-dot-com/Dockerfile (+25 -0)
➕ conformance/packages/dns-test/src/docker/ede-dot-com/configure_child.sh (+526 -0)
➕ conformance/packages/dns-test/src/docker/ede-dot-com/configure_parent.sh (+77 -0)
📝 conformance/packages/dns-test/src/fqdn.rs (+8 -0)
📝 conformance/packages/dns-test/src/implementation.rs (+13 -15)
📝 conformance/packages/dns-test/src/name_server.rs (+6 -0)
➕ conformance/packages/dns-test/src/templates/named.ede-dot-com.conf (+13 -0)
📝 tests/ede-dot-com/src/lib.rs (+425 -88)
📝 tests/ede-dot-com/src/sanity_check.rs (+12 -0)

📄 Description

Closes #2491. This adds a separate Dockerfile that builds an older version of BIND, and sets up a Docker network that mirrors extended-dns-errors.com using modified versions of the same shell scripts. Separate tests are added to test recursors against subdomains hosted by these locally-run name servers. The offline-only tests are now run in CI, to catch future regressions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2711 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/docker-ede` --- ### 📝 Commits (7) - [`7f71bfc`](https://github.com/hickory-dns/hickory-dns/commit/7f71bfc73dab57d0093a0f4004e5e073a908daca) ede-dot-com: ignore failing test - [`0e21dda`](https://github.com/hickory-dns/hickory-dns/commit/0e21dda4423c66fa1f6d725d46b7938e2553d23a) ede-dot-com: reconcile list of subdomains - [`f14a978`](https://github.com/hickory-dns/hickory-dns/commit/f14a978153a0f0fd599ca874109acd83feb6c2f6) ede-dot-com: unignore passing tests - [`9860cef`](https://github.com/hickory-dns/hickory-dns/commit/9860cefaefccbfb10cd76e9eecda27f47739cdba) ede-dot-com: add tests using Docker network - [`ebd23c1`](https://github.com/hickory-dns/hickory-dns/commit/ebd23c111d7a9a5f1fa648d2eac4f7f68bc56799) ede-dot-com: only generate one child zone per test - [`f858555`](https://github.com/hickory-dns/hickory-dns/commit/f85855561dbc5b2edfb4cee1f82036c28deb30ed) ci: run ede-dot-com tests that don't use internet - [`993bf0e`](https://github.com/hickory-dns/hickory-dns/commit/993bf0eef5a9cde79fb5c8bc486537c063a0985c) ede-dot-com: add reasons to ignore attributes ### 📊 Changes **11 files changed** (+1130 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/conformance.yml` (+3 -0) 📝 `conformance/packages/dns-test/src/container.rs` (+22 -0) ➕ `conformance/packages/dns-test/src/docker/ede-dot-com/Dockerfile` (+25 -0) ➕ `conformance/packages/dns-test/src/docker/ede-dot-com/configure_child.sh` (+526 -0) ➕ `conformance/packages/dns-test/src/docker/ede-dot-com/configure_parent.sh` (+77 -0) 📝 `conformance/packages/dns-test/src/fqdn.rs` (+8 -0) 📝 `conformance/packages/dns-test/src/implementation.rs` (+13 -15) 📝 `conformance/packages/dns-test/src/name_server.rs` (+6 -0) ➕ `conformance/packages/dns-test/src/templates/named.ede-dot-com.conf` (+13 -0) 📝 `tests/ede-dot-com/src/lib.rs` (+425 -88) 📝 `tests/ede-dot-com/src/sanity_check.rs` (+12 -0) </details> ### 📄 Description Closes #2491. This adds a separate Dockerfile that builds an older version of BIND, and sets up a Docker network that mirrors `extended-dns-errors.com` using modified versions of the same shell scripts. Separate tests are added to test recursors against subdomains hosted by these locally-run name servers. The offline-only tests are now run in CI, to catch future regressions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>