[PR #3225] [MERGED] Small `ResolverOpts` tidying #3659

New issue

Closed

opened 2026-03-16 11:55:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3225
Author: @cpu
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @cpu

Base: main ← Head: cpu-resolver-config-tweaks

📝 Commits (2)

ba08b66 resolver: tweak ip_strategy config field comment
30a6f2c resolver: rm unimplemented check_names config field

📊 Changes

1 file changed (+1 additions, -11 deletions)

View changed files

📝 crates/resolver/src/config.rs (+1 -11)

📄 Description

I was in the area wiring through some new settings in a WIP branch and wanted to lift out these tiny cleanups.

First, a tiny commit to describe ip_strategy more clearly.

Then, a second commit to remove a field that was a no-op. This is a breaking change in the event someone has specified the field in their config, but it never did anything and we're accepting breaking changes in main so we might as well get rid of it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3225 **Author:** [@cpu](https://github.com/cpu) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-resolver-config-tweaks` --- ### 📝 Commits (2) - [`ba08b66`](https://github.com/hickory-dns/hickory-dns/commit/ba08b66bfb93a4f3cfeb56722fd41a20f7c2731c) resolver: tweak ip_strategy config field comment - [`30a6f2c`](https://github.com/hickory-dns/hickory-dns/commit/30a6f2cdd719ac0c7a4b8a3576ea9aab4d660586) resolver: rm unimplemented check_names config field ### 📊 Changes **1 file changed** (+1 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/config.rs` (+1 -11) </details> ### 📄 Description I was in the area wiring through some new settings in a WIP branch and wanted to lift out these tiny cleanups. First, a tiny commit to describe `ip_strategy` more clearly. Then, a second commit to remove a field that was a no-op. This is a breaking change in the event someone has specified the field in their config, but it never did anything and we're accepting breaking changes in `main` so we might as well get rid of it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>