[PR #2677] [MERGED] Miscellaneous cleanup #3225

New issue

Closed

opened 2026-03-16 11:32:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:32:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2677
Author: @divergentdave
Created: 12/13/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @djc

Base: main ← Head: david/misc-cleanup

📝 Commits (2)

59301ee proto: fix incorrect comments
33de9be server: remove unnecessary allow attribute

📊 Changes

3 files changed (+1 additions, -7 deletions)

View changed files

📝 crates/proto/src/rr/rdata/caa.rs (+0 -4)
📝 crates/proto/src/xfer/dnssec_dns_handle/mod.rs (+1 -1)
📝 crates/server/src/store/forwarder/authority.rs (+0 -2)

📄 Description

This fixes some outdated comments and removes an unnecessary #[allow] attribute.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2677 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/misc-cleanup` --- ### 📝 Commits (2) - [`59301ee`](https://github.com/hickory-dns/hickory-dns/commit/59301eeedd05681d6ce7971c96e127be82ae6fa8) proto: fix incorrect comments - [`33de9be`](https://github.com/hickory-dns/hickory-dns/commit/33de9be4357840c2309f1307f49243b4cc5d2afc) server: remove unnecessary allow attribute ### 📊 Changes **3 files changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/caa.rs` (+0 -4) 📝 `crates/proto/src/xfer/dnssec_dns_handle/mod.rs` (+1 -1) 📝 `crates/server/src/store/forwarder/authority.rs` (+0 -2) </details> ### 📄 Description This fixes some outdated comments and removes an unnecessary `#[allow]` attribute. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>