[PR #3222] [MERGED] Pass NotAuth error through catalog #3657

New issue

Closed

opened 2026-03-16 11:55:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3222
Author: @divergentdave
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @divergentdave

Base: main ← Head: david/propagate-notauth

📝 Commits (1)

2aa79ee Pass NotAuth error through catalog

📊 Changes

2 files changed (+89 additions, -8 deletions)

View changed files

📝 crates/server/src/authority/catalog.rs (+8 -5)
📝 tests/integration-tests/tests/integration/catalog_tests.rs (+81 -3)

📄 Description

This fixes an issue I ran into while working on a larger change, propagating NotAuth response codes into authoritative responses. We use REFUSED and NotAuth in different circumstances when rejecting AXFR requests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3222 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/propagate-notauth` --- ### 📝 Commits (1) - [`2aa79ee`](https://github.com/hickory-dns/hickory-dns/commit/2aa79ee9733dcf831115ab1a1b25d7ccf8b36a5f) Pass NotAuth error through catalog ### 📊 Changes **2 files changed** (+89 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/authority/catalog.rs` (+8 -5) 📝 `tests/integration-tests/tests/integration/catalog_tests.rs` (+81 -3) </details> ### 📄 Description This fixes an issue I ran into while working on a larger change, propagating NotAuth response codes into authoritative responses. We use REFUSED and NotAuth in different circumstances when rejecting AXFR requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>