[PR #2669] [MERGED] Fix conformance test DNSSEC feature handling #3222

New issue

Closed

opened 2026-03-16 11:31:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:31:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2669
Author: @divergentdave
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @djc

Base: main ← Head: david/fix-conformance-dnssec

📝 Commits (2)

dbdabda Fix selection of PEM versus PKCS #8 key file
9e05e79 Set explicit DNSSEC feature in conformance-ignored

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 conformance/packages/dns-test/src/implementation.rs (+2 -1)
📝 justfile (+1 -1)

📄 Description

I realized my change to switch the default DNSSEC feature used in conformance tests was incomplete, because the logic to pick between a PEM or PKCS #8 key needs to change as well. As a result, some of the ignored tests have been failing for the wrong reason. This PR fixes that, and updates the conformance-ignored recipe so that it uses the same value for DNS_TEST_SUBJECT as conformance-hickory-ring.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2669 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/fix-conformance-dnssec` --- ### 📝 Commits (2) - [`dbdabda`](https://github.com/hickory-dns/hickory-dns/commit/dbdabda5d30cb71eff5d4874cab73e6629779d61) Fix selection of PEM versus PKCS #8 key file - [`9e05e79`](https://github.com/hickory-dns/hickory-dns/commit/9e05e79a9b8898398c672b3e77bcd018e9cde493) Set explicit DNSSEC feature in conformance-ignored ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/implementation.rs` (+2 -1) 📝 `justfile` (+1 -1) </details> ### 📄 Description I realized my change to switch the default DNSSEC feature used in conformance tests was incomplete, because the logic to pick between a PEM or PKCS #8 key needs to change as well. As a result, some of the ignored tests have been failing for the wrong reason. This PR fixes that, and updates the `conformance-ignored` recipe so that it uses the same value for `DNS_TEST_SUBJECT` as `conformance-hickory-ring`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>