[PR #3149] [MERGED] Move error response codes to other error variants #3597

New issue

Closed

opened 2026-03-16 11:52:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:52:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3149
Author: @divergentdave
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @divergentdave

Base: main ← Head: david/rcode-errors

📝 Commits (4)

33e71ad Use ProtoErrorKind:RequestRefused w/ RCODE=REFUSED
8f9f6fb Don't penalize server statistics for REFUSED
aad4e0a Add new error variant for other response codes
2ef5813 Simplify match patterns

📊 Changes

5 files changed (+31 additions, -47 deletions)

View changed files

📝 crates/proto/src/error.rs (+7 -15)
📝 crates/resolver/src/name_server/name_server.rs (+4 -5)
📝 crates/resolver/src/name_server/name_server_pool.rs (+4 -5)
📝 tests/ede-dot-com/src/lib.rs (+0 -6)
📝 tests/integration-tests/tests/integration/name_server_pool_tests.rs (+16 -16)

📄 Description

This fixes #3142. Handling of error response codes is moved from NoRecordsFound to RequestRefused and a new variant.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3149 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/rcode-errors` --- ### 📝 Commits (4) - [`33e71ad`](https://github.com/hickory-dns/hickory-dns/commit/33e71add6951070162e56762fc84aad6d21c15c0) Use ProtoErrorKind:RequestRefused w/ RCODE=REFUSED - [`8f9f6fb`](https://github.com/hickory-dns/hickory-dns/commit/8f9f6fbe70f377827bf7e362b267d08a86406489) Don't penalize server statistics for REFUSED - [`aad4e0a`](https://github.com/hickory-dns/hickory-dns/commit/aad4e0ad1d17427e5ea1aac9fc04781ef850bdcc) Add new error variant for other response codes - [`2ef5813`](https://github.com/hickory-dns/hickory-dns/commit/2ef5813d54268a0a8cf4804d3076aa3253fd5c64) Simplify match patterns ### 📊 Changes **5 files changed** (+31 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+7 -15) 📝 `crates/resolver/src/name_server/name_server.rs` (+4 -5) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+4 -5) 📝 `tests/ede-dot-com/src/lib.rs` (+0 -6) 📝 `tests/integration-tests/tests/integration/name_server_pool_tests.rs` (+16 -16) </details> ### 📄 Description This fixes #3142. Handling of error response codes is moved from `NoRecordsFound` to `RequestRefused` and a new variant. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>