mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[PR #2565] [CLOSED] fix: modify UDP port assignment to be handled by the OS #3142
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#3142
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/2565
Author: @wosienko
Created: 11/10/2024
Status: ❌ Closed
Base:
main← Head:patch-1📝 Commits (4)
5ebeba5fix: modify UDP port assignment to be handled by the OSc6dc0bcUpdate udp_stream.rs277933bfeat: added new feature to enable OS-level port assignmentba1a7f9feat: moved logic from feature to resolver opts📊 Changes
5 files changed (+60 additions, -27 deletions)
View changed files
📝
crates/proto/src/tests/udp.rs(+1 -0)📝
crates/proto/src/udp/udp_client_stream.rs(+16 -1)📝
crates/proto/src/udp/udp_stream.rs(+39 -26)📝
crates/resolver/src/config.rs(+3 -0)📝
crates/resolver/src/name_server/connection_provider.rs(+1 -0)📄 Description
Hi,
In the current implementation of the UDP port assignment, the compiled binary triggers Windows Firewall whenever it requests a particular port directly.
However, should the ephemeral port request be relayed to the OS directly, everything still works, is handled automatically and no firewall is triggered.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.