[PR #3123] [MERGED] Add recursor metrics #3577

New issue

Closed

opened 2026-03-16 11:51:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:51:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3123
Author: @divergentdave
Created: 7/16/2025
Status: ✅ Merged
Merged: 7/20/2025
Merged by: @djc

Base: main ← Head: david/recursor-metrics

📝 Commits (4)

d8e1ace Add metric for number of outgoing queries made
8057c2c Add counters for recursor cache hits and misses
adb2b73 Only run metrics test when the exporter is enabled
dd5ff0a Replace string literal with variable

📊 Changes

12 files changed (+557 additions, -5 deletions)

View changed files

📝 Cargo.lock (+13 -0)
📝 Cargo.toml (+1 -0)
📝 bin/tests/integration/main.rs (+1 -1)
📝 crates/proto/src/op/message.rs (+1 -2)
📝 crates/recursor/Cargo.toml (+4 -0)
📝 crates/recursor/src/lib.rs (+2 -0)
➕ crates/recursor/src/metrics_tests.rs (+456 -0)
📝 crates/recursor/src/recursor.rs (+13 -0)
📝 crates/recursor/src/recursor_dns_handle.rs (+46 -0)
📝 crates/recursor/src/recursor_pool.rs (+18 -0)
📝 crates/server/Cargo.toml (+1 -1)
📝 crates/server/src/server/metrics.rs (+1 -1)

📄 Description

This adds some basic metrics in the recursor crate, tracking cache hits and misses, as well as the total number of iterative queries made. I also tweaked the feature gate on the relevant integration test, to avoid failures with exotic feature combinations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3123 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/16/2025 **Status:** ✅ Merged **Merged:** 7/20/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/recursor-metrics` --- ### 📝 Commits (4) - [`d8e1ace`](https://github.com/hickory-dns/hickory-dns/commit/d8e1ace37c7b53d1f316254c5ac1bb67a9bc4d54) Add metric for number of outgoing queries made - [`8057c2c`](https://github.com/hickory-dns/hickory-dns/commit/8057c2c2d1c7fb76522d7899332762f9e0d30389) Add counters for recursor cache hits and misses - [`adb2b73`](https://github.com/hickory-dns/hickory-dns/commit/adb2b73959c0608de29596dbea35a21589ebe441) Only run metrics test when the exporter is enabled - [`dd5ff0a`](https://github.com/hickory-dns/hickory-dns/commit/dd5ff0a194911ed200ad8f8d3d1a6ee449ae8e21) Replace string literal with variable ### 📊 Changes **12 files changed** (+557 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+13 -0) 📝 `Cargo.toml` (+1 -0) 📝 `bin/tests/integration/main.rs` (+1 -1) 📝 `crates/proto/src/op/message.rs` (+1 -2) 📝 `crates/recursor/Cargo.toml` (+4 -0) 📝 `crates/recursor/src/lib.rs` (+2 -0) ➕ `crates/recursor/src/metrics_tests.rs` (+456 -0) 📝 `crates/recursor/src/recursor.rs` (+13 -0) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+46 -0) 📝 `crates/recursor/src/recursor_pool.rs` (+18 -0) 📝 `crates/server/Cargo.toml` (+1 -1) 📝 `crates/server/src/server/metrics.rs` (+1 -1) </details> ### 📄 Description This adds some basic metrics in the recursor crate, tracking cache hits and misses, as well as the total number of iterative queries made. I also tweaked the feature gate on the relevant integration test, to avoid failures with exotic feature combinations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>