[PR #2538] [MERGED] CI: Remove continue-on-error from steps #3123

New issue

Closed

opened 2026-03-16 11:26:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:26:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2538
Author: @divergentdave
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @djc

Base: main ← Head: david/ci-fix-clippy

📝 Commits (2)

e6da9bc CI: Remove continue-on-error from steps
47980b7 Fix Clippy warning

📊 Changes

2 files changed (+4 additions, -5 deletions)

View changed files

📝 .github/workflows/test.yml (+3 -3)
📝 crates/proto/src/multicast/mdns_stream.rs (+1 -2)

📄 Description

I noticed that there's currently a clippy warning on main, and CI is still passing because of a continue-on-error: true setting on the relevant step. This PR removes those lines, and adds if: success() || failure() to all subsequent steps. (This overrides the default of if: success()) This achieves the same goal of not short-circuiting, and running as many checks as possible even if one fails, without accidentally ignoring earlier failures.

The downside of this approach is that these later commands with success() || failure() conditions will still run even if, for example, checking out the code or installing dependencies fails. This would create some extra error messages that would be confusing, but fixing that would require adding IDs to steps and writing more complicated conditions, and I don't think that would be worth it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2538 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/ci-fix-clippy` --- ### 📝 Commits (2) - [`e6da9bc`](https://github.com/hickory-dns/hickory-dns/commit/e6da9bc6bea208a1970ec91eed7b3cc8d6d7a017) CI: Remove continue-on-error from steps - [`47980b7`](https://github.com/hickory-dns/hickory-dns/commit/47980b7e02798e7480d5b59479ab025c04171ec9) Fix Clippy warning ### 📊 Changes **2 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+3 -3) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+1 -2) </details> ### 📄 Description I noticed that there's currently a clippy warning on main, and CI is still passing because of a `continue-on-error: true` setting on the relevant step. This PR removes those lines, and adds `if: success() || failure()` to all subsequent steps. (This overrides the default of `if: success()`) This achieves the same goal of not short-circuiting, and running as many checks as possible even if one fails, without accidentally ignoring earlier failures. The downside of this approach is that these later commands with `success() || failure()` conditions will still run even if, for example, checking out the code or installing dependencies fails. This would create some extra error messages that would be confusing, but fixing that would require adding IDs to steps and writing more complicated conditions, and I don't think that would be worth it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>