[PR #3122] [MERGED] Rename build info metric, revise metric descriptions #3576

New issue

Closed

opened 2026-03-16 11:51:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:51:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3122
Author: @divergentdave
Created: 7/15/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @djc

Base: main ← Head: david/metrics-editorial

📝 Commits (5)

a443613 Rename hickory_info to hickory_build_info
3f0c86a Change HELP text for hickory_build_info
722dc86 Replace direction string arguments with an enum
47aed54 Rewrite metric descriptions dependent on direction
c8ceeb8 Revise metric descriptions

📊 Changes

6 files changed (+63 additions, -34 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+10 -5)
📝 bin/tests/integration/named_metrics_tests.rs (+1 -1)
📝 crates/server/src/authority/metrics.rs (+40 -18)
📝 crates/server/src/authority/mod.rs (+1 -1)
📝 crates/server/src/server/metrics.rs (+9 -7)
📝 crates/server/src/store/metrics.rs (+2 -2)

📄 Description

This renames the hickory_info to hickory_build_info, to better align with Prometheus info metric conventions, and revises the descriptions of all the metrics. Here's a summary of all the metrics, after this PR:

File	Name	Type	Labels	Description
bin/src/hickory-dns.rs	hickory_build_info	Gauge	version	A metric with a constant '1' labeled by the version from which Hickory DNS was built.
bin/src/hickory-dns.rs	hickory_config_info	Gauge	Nine different labels	Hickory DNS configuration metadata.
bin/src/hickory-dns.rs	hickory_zones_total	Counter	store, role	Number of DNS zones in stores.
crates/server/src/authority/metrics.rs	hickory_zone_lookups_total	Counter	authority, type, role, success	Number of zone lookups.
crates/server/src/authority/metrics.rs	hickory_request_dns_classes_total	Counter	class	Number of requests by DNS class.
crates/server/src/authority/metrics.rs	hickory_response_dns_classes_total	Counter	class	Total number of resource records in responses by DNS class.
crates/server/src/authority/metrics.rs	hickory_request_record_types_total	Counter	type	Number of requests by query type.
crates/server/src/authority/metrics.rs	hickory_response_record_types_total	Counter	type	Total number of resource records in responses by record type.
crates/server/src/server/metrics.rs	hickory_request_flags_total	Counter	flag	Number of requests by header flags.
crates/server/src/server/metrics.rs	hickory_response_flags_total	Counter	flag	Number of responses by header flags.
crates/server/src/server/metrics.rs	hickory_request_protocols_total	Counter	protocol	Number of requests by transport protocol.
crates/server/src/server/metrics.rs	hickory_request_operations_total	Counter	operation	Number of requests by opcode.
crates/server/src/server/metrics.rs	hickory_response_codes_total	Counter	code	Number of responses by response code.
crates/server/src/store/metrics.rs	hickory_zone_records_total	Gauge	store	Number of resource records in zone stores.
crates/server/src/store/metrics.rs	hickory_zone_records_modified_total	Counter	operation	Number of modifications to resource records in zone stores.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3122 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/metrics-editorial` --- ### 📝 Commits (5) - [`a443613`](https://github.com/hickory-dns/hickory-dns/commit/a4436136725de8922dbd6ca083005982417ac3c6) Rename hickory_info to hickory_build_info - [`3f0c86a`](https://github.com/hickory-dns/hickory-dns/commit/3f0c86af3840621b0f9dea5212e389141758e570) Change HELP text for hickory_build_info - [`722dc86`](https://github.com/hickory-dns/hickory-dns/commit/722dc86af71284c96239376e332f27844652e374) Replace direction string arguments with an enum - [`47aed54`](https://github.com/hickory-dns/hickory-dns/commit/47aed5473389cbe872c446bb795c5a4857c3963d) Rewrite metric descriptions dependent on direction - [`c8ceeb8`](https://github.com/hickory-dns/hickory-dns/commit/c8ceeb8d09f084801266b30c9115922787dc4e50) Revise metric descriptions ### 📊 Changes **6 files changed** (+63 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+10 -5) 📝 `bin/tests/integration/named_metrics_tests.rs` (+1 -1) 📝 `crates/server/src/authority/metrics.rs` (+40 -18) 📝 `crates/server/src/authority/mod.rs` (+1 -1) 📝 `crates/server/src/server/metrics.rs` (+9 -7) 📝 `crates/server/src/store/metrics.rs` (+2 -2) </details> ### 📄 Description This renames the `hickory_info` to `hickory_build_info`, to better align with Prometheus info metric conventions, and revises the descriptions of all the metrics. Here's a summary of all the metrics, after this PR: |File|Name|Type|Labels|Description| |----|----|----|------|-----------| |bin/src/hickory-dns.rs|hickory_build_info|Gauge|version|A metric with a constant '1' labeled by the version from which Hickory DNS was built.| |bin/src/hickory-dns.rs|hickory_config_info|Gauge|Nine different labels|Hickory DNS configuration metadata.| |bin/src/hickory-dns.rs|hickory_zones_total|Counter|store, role|Number of DNS zones in stores.| |crates/server/src/authority/metrics.rs|hickory_zone_lookups_total|Counter|authority, type, role, success|Number of zone lookups.| |crates/server/src/authority/metrics.rs|hickory_request_dns_classes_total|Counter|class|Number of requests by DNS class.| |crates/server/src/authority/metrics.rs|hickory_response_dns_classes_total|Counter|class|Total number of resource records in responses by DNS class.| |crates/server/src/authority/metrics.rs|hickory_request_record_types_total|Counter|type|Number of requests by query type.| |crates/server/src/authority/metrics.rs|hickory_response_record_types_total|Counter|type|Total number of resource records in responses by record type.| |crates/server/src/server/metrics.rs|hickory_request_flags_total|Counter|flag|Number of requests by header flags.| |crates/server/src/server/metrics.rs|hickory_response_flags_total|Counter|flag|Number of responses by header flags.| |crates/server/src/server/metrics.rs|hickory_request_protocols_total|Counter|protocol|Number of requests by transport protocol.| |crates/server/src/server/metrics.rs|hickory_request_operations_total|Counter|operation|Number of requests by opcode.| |crates/server/src/server/metrics.rs|hickory_response_codes_total|Counter|code|Number of responses by response code.| |crates/server/src/store/metrics.rs|hickory_zone_records_total|Gauge|store|Number of resource records in zone stores.| |crates/server/src/store/metrics.rs|hickory_zone_records_modified_total|Counter|operation|Number of modifications to resource records in zone stores.| --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>