[PR #2541] [MERGED] Clarify `KeyPair` type #3122

New issue

Closed

opened 2026-03-16 11:26:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:26:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2541
Author: @djc
Created: 10/30/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @djc

Base: main ← Head: key-pairs

📝 Commits (6)

d2ebf95 proto: extract helper method for RSA public key serialization
4ae975b proto: extract helper method for EC public key serialization
02787ad util: avoid KeyPair type for public keys in pem-to-public-dnskey
9a0a851 proto: commit key pairs to algorithm
569b1be proto: privatize KeyPair::to_public_bytes()
30024a0 proto: require private keys inside KeyPair

📊 Changes

10 files changed (+167 additions, -145 deletions)

View changed files

📝 bin/src/dnssec.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/key_format.rs (+10 -16)
📝 crates/proto/src/rr/dnssec/keypair.rs (+70 -85)
📝 crates/proto/src/rr/dnssec/public_key.rs (+47 -3)
📝 crates/proto/src/rr/dnssec/signer.rs (+23 -17)
📝 tests/compatibility-tests/tests/integration/sig0_tests.rs (+2 -2)
📝 tests/integration-tests/src/example_authority.rs (+1 -1)
📝 tests/integration-tests/tests/integration/client_future_tests.rs (+1 -1)
📝 tests/integration-tests/tests/integration/client_tests.rs (+4 -3)
📝 util/src/bin/pem-to-public-dnskey.rs (+7 -15)

📄 Description

Continue from #2534.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2541 **Author:** [@djc](https://github.com/djc) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `key-pairs` --- ### 📝 Commits (6) - [`d2ebf95`](https://github.com/hickory-dns/hickory-dns/commit/d2ebf9572dd273f9dad1cb022d9e4174deee539d) proto: extract helper method for RSA public key serialization - [`4ae975b`](https://github.com/hickory-dns/hickory-dns/commit/4ae975b91a484d1e0af32af6f419678145e8075a) proto: extract helper method for EC public key serialization - [`02787ad`](https://github.com/hickory-dns/hickory-dns/commit/02787ada6df0fa92003cf3db4574c6496fca822c) util: avoid KeyPair type for public keys in pem-to-public-dnskey - [`9a0a851`](https://github.com/hickory-dns/hickory-dns/commit/9a0a851fb6df1bed50b1111074f03d7a0dbc9d72) proto: commit key pairs to algorithm - [`569b1be`](https://github.com/hickory-dns/hickory-dns/commit/569b1bef9ac5dccf73338cbe41e95fee915bdb43) proto: privatize KeyPair::to_public_bytes() - [`30024a0`](https://github.com/hickory-dns/hickory-dns/commit/30024a067794145ac4b19aa58f1d2b3556ee43e7) proto: require private keys inside KeyPair ### 📊 Changes **10 files changed** (+167 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/key_format.rs` (+10 -16) 📝 `crates/proto/src/rr/dnssec/keypair.rs` (+70 -85) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+47 -3) 📝 `crates/proto/src/rr/dnssec/signer.rs` (+23 -17) 📝 `tests/compatibility-tests/tests/integration/sig0_tests.rs` (+2 -2) 📝 `tests/integration-tests/src/example_authority.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+4 -3) 📝 `util/src/bin/pem-to-public-dnskey.rs` (+7 -15) </details> ### 📄 Description Continue from #2534. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>