[PR #3101] [MERGED] Customize Duration serde format in ResolverOpts #3557

Closed
opened 2026-03-16 11:50:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3101
Author: @divergentdave
Created: 7/5/2025
Status: Merged
Merged: 7/8/2025
Merged by: @djc

Base: mainHead: david/resolveropts-serde-duration


📝 Commits (1)

  • faf3905 Customize Duration serde format in ResolverOpts

📊 Changes

3 files changed (+77 additions, -19 deletions)

View changed files

📝 crates/resolver/src/cache.rs (+5 -18)
📝 crates/resolver/src/config.rs (+67 -1)
📝 tests/test-data/test_configs/example_forwarder.toml (+5 -0)

📄 Description

This changes the serialization/deserialization format of durations inside ResolverOpts to be a single number, like we currently do in the TtlBounds struct.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3101 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/5/2025 **Status:** ✅ Merged **Merged:** 7/8/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/resolveropts-serde-duration` --- ### 📝 Commits (1) - [`faf3905`](https://github.com/hickory-dns/hickory-dns/commit/faf390545ebb2bb887e223dafa3ff791b7b167fd) Customize Duration serde format in ResolverOpts ### 📊 Changes **3 files changed** (+77 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/cache.rs` (+5 -18) 📝 `crates/resolver/src/config.rs` (+67 -1) 📝 `tests/test-data/test_configs/example_forwarder.toml` (+5 -0) </details> ### 📄 Description This changes the serialization/deserialization format of durations inside `ResolverOpts` to be a single number, like we currently do in the `TtlBounds` struct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:50:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3557
No description provided.