[PR #2517] [MERGED] DNSSEC tweaks #3101

New issue

Closed

opened 2026-03-16 11:25:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2517
Author: @djc
Created: 10/18/2024
Status: ✅ Merged
Merged: 10/20/2024
Merged by: @djc

Base: main ← Head: dnssec-tweaks

📝 Commits (7)

cdcb7a0 recursor: move test below inline module
579157c proto: move DNSSEC Edns setup around
1e60168 proto: deduplicate setup of default Edns algorithms
538767e proto: avoid unnecessary DnssecDnsHandle clones
ae7074b proto: extract check_nsec() function
7676b1c proto: simplify verification setup
2f4cd2d proto: invert condition to clarify NSEC handling

📊 Changes

4 files changed (+160 additions, -145 deletions)

View changed files

📝 crates/proto/src/op/edns.rs (+30 -0)
📝 crates/proto/src/xfer/dnssec_dns_handle/mod.rs (+106 -113)
📝 crates/recursor/src/recursor.rs (+22 -18)
📝 crates/server/src/authority/catalog.rs (+2 -14)

📄 Description

Followup from reviewing #2502. Happy to rebase this on top of that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2517 **Author:** [@djc](https://github.com/djc) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 10/20/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-tweaks` --- ### 📝 Commits (7) - [`cdcb7a0`](https://github.com/hickory-dns/hickory-dns/commit/cdcb7a069237b93e2bdf382221b1dbd31d028b83) recursor: move test below inline module - [`579157c`](https://github.com/hickory-dns/hickory-dns/commit/579157cea1cba5a1f757f40d46cc1a530c31f6a3) proto: move DNSSEC Edns setup around - [`1e60168`](https://github.com/hickory-dns/hickory-dns/commit/1e6016889c23f0834d0f93d356b727b0484d9fef) proto: deduplicate setup of default Edns algorithms - [`538767e`](https://github.com/hickory-dns/hickory-dns/commit/538767ea0dbad1e454669a28e15f8cc4df55176f) proto: avoid unnecessary DnssecDnsHandle clones - [`ae7074b`](https://github.com/hickory-dns/hickory-dns/commit/ae7074b39e820b94cf03b6659f927d72577427ab) proto: extract check_nsec() function - [`7676b1c`](https://github.com/hickory-dns/hickory-dns/commit/7676b1caa20c7c9194445ff02465a3c094bb1eb4) proto: simplify verification setup - [`2f4cd2d`](https://github.com/hickory-dns/hickory-dns/commit/2f4cd2d536e02534e0177b61839fa3a1a419b6ba) proto: invert condition to clarify NSEC handling ### 📊 Changes **4 files changed** (+160 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/edns.rs` (+30 -0) 📝 `crates/proto/src/xfer/dnssec_dns_handle/mod.rs` (+106 -113) 📝 `crates/recursor/src/recursor.rs` (+22 -18) 📝 `crates/server/src/authority/catalog.rs` (+2 -14) </details> ### 📄 Description Followup from reviewing #2502. Happy to rebase this on top of that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>