[PR #3092] [MERGED] proto: do not attempt recursive DS lookup in verify_default_rrset #3551

Closed
opened 2026-03-16 11:49:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3092
Author: @marcus0x62
Created: 6/26/2025
Status: Merged
Merged: 6/26/2025
Merged by: @marcus0x62

Base: mainHead: noverify_ds_without_rrsig


📝 Commits (3)

  • 0f08ea6 dns-test: convenience function to run tshark on nameservers
  • 6e10489 e2e-tests: regression test for #3090
  • c071d0c proto: do not attempt recursive DS lookup in verify_default_rrset

📊 Changes

3 files changed (+137 additions, -6 deletions)

View changed files

📝 conformance/packages/dns-test/src/name_server.rs (+5 -0)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+10 -6)
📝 tests/e2e-tests/src/resolver/dnssec/regression.rs (+122 -0)

📄 Description

Fixes #3090


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3092 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 6/26/2025 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `noverify_ds_without_rrsig` --- ### 📝 Commits (3) - [`0f08ea6`](https://github.com/hickory-dns/hickory-dns/commit/0f08ea63c7cdfbc6d09bc782f560424b32c1e23a) dns-test: convenience function to run tshark on nameservers - [`6e10489`](https://github.com/hickory-dns/hickory-dns/commit/6e104890de298eeae888c3a0f141a194ac7ab4de) e2e-tests: regression test for #3090 - [`c071d0c`](https://github.com/hickory-dns/hickory-dns/commit/c071d0c4e1294bb4461a7da4472daefc8b3e552f) proto: do not attempt recursive DS lookup in verify_default_rrset ### 📊 Changes **3 files changed** (+137 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/name_server.rs` (+5 -0) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+10 -6) 📝 `tests/e2e-tests/src/resolver/dnssec/regression.rs` (+122 -0) </details> ### 📄 Description Fixes #3090 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:49:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3551
No description provided.