[PR #2506] [MERGED] Update the NSEC/NSEC3 Truth Table to correctly log responses with NSEC and NSEC3 records #3092

New issue

Closed

opened 2026-03-16 11:24:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:24:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2506
Author: @marcus0x62
Created: 10/13/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @bluejekyll

Base: main ← Head: nsec_truth_table

📝 Commits (1)

0548013 fix nsec/nsec3 truth table

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 crates/proto/src/xfer/dnssec_dns_handle/mod.rs (+7 -2)

📄 Description

The NSEC/NSEC3 truth table returns Bogus if there are no NSEC/NSEC3 records at all, and if both record types are present. That is fine, however the detection logic is backwards. This fixes the matching logic so the 'both record types detected' log is fired in the correct condition.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2506 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 10/13/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `nsec_truth_table` --- ### 📝 Commits (1) - [`0548013`](https://github.com/hickory-dns/hickory-dns/commit/0548013cfb236b9f17500f8c55710ad1d32debd6) fix nsec/nsec3 truth table ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/dnssec_dns_handle/mod.rs` (+7 -2) </details> ### 📄 Description The NSEC/NSEC3 truth table returns Bogus if there are no NSEC/NSEC3 records at all, and if both record types are present. That is fine, however the detection logic is backwards. This fixes the matching logic so the 'both record types detected' log is fired in the correct condition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>