[PR #3085] [MERGED] resolver: default trust_negative_responses to true #3549

New issue

Closed

opened 2026-03-16 11:49:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:49:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3085
Author: @djc
Created: 6/24/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @djc

Base: main ← Head: default-trust

📝 Commits (3)

d1c8049 resolver: default trust_negative_responses to true
d03a18c resolver: bring documentation in line with current code
d623978 resolver: reflow trust_negative_responses docstring

📊 Changes

4 files changed (+30 additions, -27 deletions)

View changed files

📝 crates/recursor/src/recursor_dns_handle.rs (+7 -9)
📝 crates/resolver/src/config.rs (+18 -16)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -1)
📝 crates/resolver/src/system_conf/windows.rs (+3 -1)

📄 Description

This resets the default for NameServerConfig::trust_negative_responses to true after I changed this in #3052 without thinking about it too much. Note that the read_system_config() code still resets trust_negative_responses to false.

As a further refinement, we could decide to trust negative responses from name servers read from the system config only if they're known to us (in the set of addresses from GOOGLE, CLOUDFLARE, QUAD9)?

Fixes #3084.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3085 **Author:** [@djc](https://github.com/djc) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `default-trust` --- ### 📝 Commits (3) - [`d1c8049`](https://github.com/hickory-dns/hickory-dns/commit/d1c8049975098607e290c68487f47e6c361bb627) resolver: default trust_negative_responses to true - [`d03a18c`](https://github.com/hickory-dns/hickory-dns/commit/d03a18ccd7f5e3632bce14f8bb0cce9854a8310b) resolver: bring documentation in line with current code - [`d623978`](https://github.com/hickory-dns/hickory-dns/commit/d623978c6acde8a9260a45975b55c27b7aadb35b) resolver: reflow trust_negative_responses docstring ### 📊 Changes **4 files changed** (+30 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor_dns_handle.rs` (+7 -9) 📝 `crates/resolver/src/config.rs` (+18 -16) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -1) 📝 `crates/resolver/src/system_conf/windows.rs` (+3 -1) </details> ### 📄 Description This resets the default for `NameServerConfig::trust_negative_responses` to `true` after I changed this in #3052 without thinking about it too much. Note that the `read_system_config()` code still resets `trust_negative_responses` to `false`. As a further refinement, we could decide to trust negative responses from name servers read from the system config only if they're known to us (in the set of addresses from `GOOGLE`, `CLOUDFLARE`, `QUAD9`)? Fixes #3084. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>