[PR #2453] [MERGED] Set up tracing subscriber in various tests #3052

New issue

Closed

opened 2026-03-16 11:22:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2453
Author: @divergentdave
Created: 9/12/2024
Status: ✅ Merged
Merged: 9/13/2024
Merged by: @djc

Base: main ← Head: david/test-tracing-subscriber

📝 Commits (1)

7b2cfc5 Set up tracing subscriber in various tests

📊 Changes

31 files changed (+157 additions, -64 deletions)

View changed files

📝 .github/dependabot.yml (+0 -3)
📝 Cargo.lock (+2 -0)
📝 Cargo.toml (+1 -1)
📝 bin/Cargo.toml (+1 -1)
📝 bin/tests/integration/main.rs (+15 -0)
📝 bin/tests/integration/named_https_tests.rs (+2 -1)
📝 bin/tests/integration/named_quic_tests.rs (+5 -2)
📝 bin/tests/integration/named_tests.rs (+5 -2)
📝 crates/async-std-resolver/Cargo.toml (+2 -0)
📝 crates/async-std-resolver/src/tests.rs (+16 -0)
📝 crates/client/Cargo.toml (+1 -1)
📝 crates/proto/Cargo.toml (+1 -1)
📝 crates/proto/src/h2/h2_client_stream.rs (+4 -3)
📝 crates/proto/src/h3/h3_client_stream.rs (+4 -3)
📝 crates/proto/src/multicast/mdns_stream.rs (+2 -3)
📝 crates/proto/src/tests/mod.rs (+17 -0)
📝 crates/proto/src/tests/udp.rs (+0 -3)
📝 crates/proto/src/udp/udp_client_stream.rs (+3 -1)
📝 crates/recursor/Cargo.toml (+1 -1)
📝 crates/resolver/Cargo.toml (+1 -1)

...and 11 more files

📄 Description

This PR sets up a tracing subscriber in various tests that currently have a commented-out env_logger initialization. The one existing use of tracing subscribers in a test is converted over to match, so it uses tracing::subscriber::set_global_default() instead of tracing::subscriber::set_default(), since the latter only works on the current thread. This closes #2445.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2453 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/12/2024 **Status:** ✅ Merged **Merged:** 9/13/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/test-tracing-subscriber` --- ### 📝 Commits (1) - [`7b2cfc5`](https://github.com/hickory-dns/hickory-dns/commit/7b2cfc56925bf56429abf4232671e7014c275fb6) Set up tracing subscriber in various tests ### 📊 Changes **31 files changed** (+157 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.github/dependabot.yml` (+0 -3) 📝 `Cargo.lock` (+2 -0) 📝 `Cargo.toml` (+1 -1) 📝 `bin/Cargo.toml` (+1 -1) 📝 `bin/tests/integration/main.rs` (+15 -0) 📝 `bin/tests/integration/named_https_tests.rs` (+2 -1) 📝 `bin/tests/integration/named_quic_tests.rs` (+5 -2) 📝 `bin/tests/integration/named_tests.rs` (+5 -2) 📝 `crates/async-std-resolver/Cargo.toml` (+2 -0) 📝 `crates/async-std-resolver/src/tests.rs` (+16 -0) 📝 `crates/client/Cargo.toml` (+1 -1) 📝 `crates/proto/Cargo.toml` (+1 -1) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+4 -3) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+4 -3) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -3) 📝 `crates/proto/src/tests/mod.rs` (+17 -0) 📝 `crates/proto/src/tests/udp.rs` (+0 -3) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+3 -1) 📝 `crates/recursor/Cargo.toml` (+1 -1) 📝 `crates/resolver/Cargo.toml` (+1 -1) _...and 11 more files_ </details> ### 📄 Description This PR sets up a tracing subscriber in various tests that currently have a commented-out `env_logger` initialization. The one existing use of tracing subscribers in a test is converted over to match, so it uses `tracing::subscriber::set_global_default()` instead of `tracing::subscriber::set_default()`, since the latter only works on the current thread. This closes #2445. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>