[PR #3029] [MERGED] resolver: introduce ServerGroup type to replace NameServerGroupConfig #3508

New issue

Closed

opened 2026-03-16 11:47:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:47:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3029
Author: @djc
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @djc

Base: main ← Head: public-dns

📝 Commits (6)

071b260 resolver: centralize public DNS server names
df50bcf resolver: introduce ServerGroup type
8eea4f0 resolver: store HTTP query path in ServerGroup
53689bd resolver: use ServerGroup for AdGuard test
88e5fd8 resolver: move logic into ServerGroup methods
585c6a1 resolver: discard NameServerConfigGroup type

📊 Changes

16 files changed (+388 additions, -580 deletions)

View changed files

📝 crates/recursor/src/lib.rs (+1 -1)
📝 crates/recursor/src/recursor_dns_handle.rs (+25 -11)
📝 crates/resolver/README.md (+1 -1)
📝 crates/resolver/examples/custom_provider.rs (+7 -4)
📝 crates/resolver/examples/global_resolver.rs (+2 -2)
📝 crates/resolver/examples/multithreaded_runtime.rs (+2 -2)
📝 crates/resolver/src/config.rs (+187 -491)
📝 crates/resolver/src/lib.rs (+2 -2)
📝 crates/resolver/src/name_server/connection_provider.rs (+24 -19)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -3)
📝 crates/resolver/src/resolver.rs (+39 -26)
📝 crates/resolver/src/tests.rs (+6 -4)
➕ crates/resolver/src/tls.rs (+79 -0)
📝 crates/server/src/store/forwarder.rs (+3 -3)
📝 tests/integration-tests/tests/integration/validating_forwarder_tests.rs (+2 -5)
📝 util/src/bin/resolve.rs (+6 -6)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3029 **Author:** [@djc](https://github.com/djc) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/13/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `public-dns` --- ### 📝 Commits (6) - [`071b260`](https://github.com/hickory-dns/hickory-dns/commit/071b260364b462aa2f4158923f097c15066c413f) resolver: centralize public DNS server names - [`df50bcf`](https://github.com/hickory-dns/hickory-dns/commit/df50bcf191fb88e0ac1438a4c8cf669efcf3aab5) resolver: introduce ServerGroup type - [`8eea4f0`](https://github.com/hickory-dns/hickory-dns/commit/8eea4f078fcdcd38b1ae38d3dbdd31ebc26d7605) resolver: store HTTP query path in ServerGroup - [`53689bd`](https://github.com/hickory-dns/hickory-dns/commit/53689bdd272ecd5e17b2130aefe5732ec93a267d) resolver: use ServerGroup for AdGuard test - [`88e5fd8`](https://github.com/hickory-dns/hickory-dns/commit/88e5fd87421a1faed92de93a10a5dc491f508e37) resolver: move logic into ServerGroup methods - [`585c6a1`](https://github.com/hickory-dns/hickory-dns/commit/585c6a1d8aaff0eebb865cab87437d34c0767269) resolver: discard NameServerConfigGroup type ### 📊 Changes **16 files changed** (+388 additions, -580 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/lib.rs` (+1 -1) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+25 -11) 📝 `crates/resolver/README.md` (+1 -1) 📝 `crates/resolver/examples/custom_provider.rs` (+7 -4) 📝 `crates/resolver/examples/global_resolver.rs` (+2 -2) 📝 `crates/resolver/examples/multithreaded_runtime.rs` (+2 -2) 📝 `crates/resolver/src/config.rs` (+187 -491) 📝 `crates/resolver/src/lib.rs` (+2 -2) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+24 -19) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -3) 📝 `crates/resolver/src/resolver.rs` (+39 -26) 📝 `crates/resolver/src/tests.rs` (+6 -4) ➕ `crates/resolver/src/tls.rs` (+79 -0) 📝 `crates/server/src/store/forwarder.rs` (+3 -3) 📝 `tests/integration-tests/tests/integration/validating_forwarder_tests.rs` (+2 -5) 📝 `util/src/bin/resolve.rs` (+6 -6) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>