[PR #2417] [MERGED] implement rfc4398 CERT record type #3029

New issue

Closed

opened 2026-03-16 11:21:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2417
Author: @zsdsys
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @djc

Base: main ← Head: main

📝 Commits (10+)

cb12bdf implement rfc4398 CERT record type
1f1a3ec fix formating
8ec60c0 Merge branch 'main' into main
18890c7 fix test order
9f6233f Merge branch 'main' into main
58d6e86 rework to utilize enums, finish parser, add tests
bfb0633 fix double decode, tests
d22fdc9 cleanup annotations, enums, position; try_from
aaaf97c Merge branch 'main' into main
8551606 formating

📊 Changes

9 files changed (+947 additions, -3 deletions)

View changed files

➕ crates/proto/src/rr/rdata/cert.rs (+762 -0)
📝 crates/proto/src/rr/rdata/mod.rs (+2 -0)
📝 crates/proto/src/rr/record_data.rs (+27 -2)
📝 crates/proto/src/rr/record_type.rs (+15 -1)
📝 crates/proto/src/serialize/txt/parse_rdata.rs (+1 -0)
➕ crates/proto/src/serialize/txt/rdata_parsers/cert.rs (+131 -0)
📝 crates/proto/src/serialize/txt/rdata_parsers/mod.rs (+1 -0)
📝 crates/resolver/src/async_resolver.rs (+1 -0)
📝 crates/resolver/src/lookup.rs (+7 -0)

📄 Description

this PR implements rfc4398 RecordType::CERT for querying CERT records.

I have run into a snag with DNSSEC verification of returned records with the error: rrsigs were not able to be verified. I can see RRSIG CERT ECDSAP256SHA256 returned in my debug tests but was unsure how to resolve the error

~~any insights/suggestions would be appreciated~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2417 **Author:** [@zsdsys](https://github.com/zsdsys) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`cb12bdf`](https://github.com/hickory-dns/hickory-dns/commit/cb12bdf0316dd39e79fb57f18ed4041296ea4bd1) implement rfc4398 CERT record type - [`1f1a3ec`](https://github.com/hickory-dns/hickory-dns/commit/1f1a3ecf8600759b22d3e0b43b651ab3a4695197) fix formating - [`8ec60c0`](https://github.com/hickory-dns/hickory-dns/commit/8ec60c02ee099c120aaf3e90b65a56593774bc16) Merge branch 'main' into main - [`18890c7`](https://github.com/hickory-dns/hickory-dns/commit/18890c7127493b8ffb485bb3e413d051cb8759d9) fix test order - [`9f6233f`](https://github.com/hickory-dns/hickory-dns/commit/9f6233f31b10a74afcce25121142389b93b1b38b) Merge branch 'main' into main - [`58d6e86`](https://github.com/hickory-dns/hickory-dns/commit/58d6e86a0309f484a121cc2a4b9f1d1a48113df7) rework to utilize enums, finish parser, add tests - [`bfb0633`](https://github.com/hickory-dns/hickory-dns/commit/bfb06332e75ad240d266b320e87bed4b173e7ec5) fix double decode, tests - [`d22fdc9`](https://github.com/hickory-dns/hickory-dns/commit/d22fdc93e1c1f4dc5ecd1101121142a471f1bd57) cleanup annotations, enums, position; try_from - [`aaaf97c`](https://github.com/hickory-dns/hickory-dns/commit/aaaf97c7fe7d36b27271f76e37411b068337996d) Merge branch 'main' into main - [`8551606`](https://github.com/hickory-dns/hickory-dns/commit/8551606e043511a789e962f1d627bcfa7c8d446c) formating ### 📊 Changes **9 files changed** (+947 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `crates/proto/src/rr/rdata/cert.rs` (+762 -0) 📝 `crates/proto/src/rr/rdata/mod.rs` (+2 -0) 📝 `crates/proto/src/rr/record_data.rs` (+27 -2) 📝 `crates/proto/src/rr/record_type.rs` (+15 -1) 📝 `crates/proto/src/serialize/txt/parse_rdata.rs` (+1 -0) ➕ `crates/proto/src/serialize/txt/rdata_parsers/cert.rs` (+131 -0) 📝 `crates/proto/src/serialize/txt/rdata_parsers/mod.rs` (+1 -0) 📝 `crates/resolver/src/async_resolver.rs` (+1 -0) 📝 `crates/resolver/src/lookup.rs` (+7 -0) </details> ### 📄 Description this PR implements rfc4398 RecordType::CERT for querying CERT records. ~~I have run into a snag with DNSSEC verification of returned records with the error: rrsigs were not able to be verified. I can see RRSIG CERT ECDSAP256SHA256 returned in my debug tests but was unsure how to resolve the error~~ ~~any insights/suggestions would be appreciated~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>