[PR #2983] [MERGED] Make one more NS query to better align with RFC 9156 #3471

New issue

Closed

opened 2026-03-16 11:45:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:45:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2983
Author: @divergentdave
Created: 5/9/2025
Status: ✅ Merged
Merged: 5/19/2025
Merged by: @divergentdave

Base: main ← Head: david/qname-minimization-last-query

📝 Commits (1)

75691d8 Make one more NS query to better align w/ RFC 9156

📊 Changes

4 files changed (+71 additions, -246 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+18 -4)
📝 crates/recursor/src/recursor_dns_handle.rs (+38 -234)
📝 crates/server/src/store/recursor.rs (+2 -2)
📝 tests/e2e-tests/src/recursor/delegation/scenarios.rs (+13 -6)

📄 Description

This implements #2938, to better align with the QNAME minimization algorithm in RFC 9156. We now only send the original query once. This PR removes a significant amount of code that handled referral responses in the event that the QNAME is at a zone apex. I had to rework the name server topology in one ignored conformance test so that it still exercises the same incorrect caching behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2983 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/qname-minimization-last-query` --- ### 📝 Commits (1) - [`75691d8`](https://github.com/hickory-dns/hickory-dns/commit/75691d816e01fe7aec3b9d7a908cc5fd15929704) Make one more NS query to better align w/ RFC 9156 ### 📊 Changes **4 files changed** (+71 additions, -246 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+18 -4) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+38 -234) 📝 `crates/server/src/store/recursor.rs` (+2 -2) 📝 `tests/e2e-tests/src/recursor/delegation/scenarios.rs` (+13 -6) </details> ### 📄 Description This implements #2938, to better align with the QNAME minimization algorithm in RFC 9156. We now only send the original query once. This PR removes a significant amount of code that handled referral responses in the event that the QNAME is at a zone apex. I had to rework the name server topology in one ignored conformance test so that it still exercises the same incorrect caching behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>