[PR #2359] [MERGED] use a "test" TLD in conformance tests #2983

New issue

Closed

opened 2026-03-16 11:18:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:18:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2359
Author: @japaric
Created: 8/15/2024
Status: ✅ Merged
Merged: 8/26/2024
Merged by: @japaric

Base: main ← Head: ja-test-tld

📝 Commits (3)

80d8450 refactor example.nameservers.com. into a constant
f7f6861 rename FQDN::NAMESERVERS to TEST_DOMAIN
c678a8a use a "test" TLD in conformance tests

📊 Changes

15 files changed (+76 additions, -57 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/adhoc.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs (+5 -5)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+4 -4)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs (+9 -5)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_6.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs (+6 -6)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+3 -3)
📝 conformance/packages/dns-test/src/fqdn.rs (+11 -10)
📝 conformance/packages/dns-test/src/name_server.rs (+23 -9)
📝 conformance/packages/dns-test/src/record.rs (+2 -2)
📝 conformance/packages/dns-test/src/tshark.rs (+2 -2)
📝 tests/e2e-tests/src/resolver/dnssec/regression.rs (+2 -2)

📄 Description

This is to make it clearer, when discussing bugs in the issue tracker, that DNS queries happen within a test DNS environment.

example.hickory-dns.testing. is clearly not a public domain and *.hickory-dns.testing. domains won't overlap with existing public domains (hopefully)

Note that we do NOT use the test. TLD which is a reserved TLD in the DNS specification because RFC6761 lets DNS implementations diverge from the DNS specification when dealing with that TLD.

Namely, unbound appears to make use of that allowance (RFC6761) because it behaves differently when dealing with **.test. domains and that leads to over 16 conformance test failures. In contrast, BIND passes all conformance tests when the test. TLD is used.

also see this thread https://github.com/hickory-dns/hickory-dns/issues/2192#issuecomment-2119013440

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2359 **Author:** [@japaric](https://github.com/japaric) **Created:** 8/15/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-test-tld` --- ### 📝 Commits (3) - [`80d8450`](https://github.com/hickory-dns/hickory-dns/commit/80d8450c6e2b8bb2d2cd4b4826eda2c8818b1d87) refactor example.nameservers.com. into a constant - [`f7f6861`](https://github.com/hickory-dns/hickory-dns/commit/f7f6861057233c3171a44b79efaaa52f18ae2e8d) rename FQDN::NAMESERVERS to TEST_DOMAIN - [`c678a8a`](https://github.com/hickory-dns/hickory-dns/commit/c678a8ab12836988d9b5a36f527fa410311557e3) use a "test" TLD in conformance tests ### 📊 Changes **15 files changed** (+76 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/adhoc.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs` (+5 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+4 -4) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs` (+9 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_6.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs` (+6 -6) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+3 -3) 📝 `conformance/packages/dns-test/src/fqdn.rs` (+11 -10) 📝 `conformance/packages/dns-test/src/name_server.rs` (+23 -9) 📝 `conformance/packages/dns-test/src/record.rs` (+2 -2) 📝 `conformance/packages/dns-test/src/tshark.rs` (+2 -2) 📝 `tests/e2e-tests/src/resolver/dnssec/regression.rs` (+2 -2) </details> ### 📄 Description This is to make it clearer, when discussing bugs in the issue tracker, that DNS queries happen within a test DNS environment. `example.hickory-dns.testing.` is clearly not a public domain and `*.hickory-dns.testing.` domains won't overlap with existing public domains (hopefully) Note that we do NOT use the `test.` TLD which is a reserved TLD in the DNS specification because RFC6761 lets DNS implementations diverge from the DNS specification when dealing with that TLD. Namely, `unbound` appears to make use of that allowance (RFC6761) because it behaves differently when dealing with `**.test.` domains and that leads to over 16 conformance test failures. In contrast, BIND passes all conformance tests when the `test.` TLD is used. also see this thread https://github.com/hickory-dns/hickory-dns/issues/2192#issuecomment-2119013440 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>