[PR #2981] [MERGED] Make SOA record optional in AuthorityData #3469

New issue

Closed

opened 2026-03-16 11:45:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:45:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2981
Author: @divergentdave
Created: 5/8/2025
Status: ✅ Merged
Merged: 5/8/2025
Merged by: @djc

Base: main ← Head: david/authority-data-optional-soa

📝 Commits (1)

4376099 Make SOA record optional in AuthorityData

📊 Changes

3 files changed (+6 additions, -9 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios/no_soa.rs (+0 -1)
📝 crates/proto/src/error.rs (+3 -3)
📝 crates/recursor/src/error.rs (+3 -5)

📄 Description

This makes the soa field in AuthorityData optional, which removes an error edge case that was too strict. Closes #2814.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2981 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/8/2025 **Status:** ✅ Merged **Merged:** 5/8/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/authority-data-optional-soa` --- ### 📝 Commits (1) - [`4376099`](https://github.com/hickory-dns/hickory-dns/commit/4376099a7b936d3d3d34fc2e2378a15802e101f5) Make SOA record optional in AuthorityData ### 📊 Changes **3 files changed** (+6 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios/no_soa.rs` (+0 -1) 📝 `crates/proto/src/error.rs` (+3 -3) 📝 `crates/recursor/src/error.rs` (+3 -5) </details> ### 📄 Description This makes the `soa` field in `AuthorityData` optional, which removes an error edge case that was too strict. Closes #2814. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>