[PR #2361] [MERGED] Fix stdout handling during hickory startup #2981

New issue

Closed

opened 2026-03-16 11:18:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:18:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2361
Author: @justahero
Created: 8/15/2024
Status: ✅ Merged
Merged: 8/23/2024
Merged by: @japaric

Base: main ← Head: sz-fix-hickory-stdout-output

📝 Commits (1)

3c4c9b4 Fix stdout handling during hickory startup

📊 Changes

2 files changed (+16 additions, -6 deletions)

View changed files

📝 conformance/packages/dns-test/src/container.rs (+7 -0)
📝 conformance/packages/dns-test/src/resolver.rs (+9 -6)

📄 Description

During the startup sequence of hickory a specific output is expected. This startup sequence consumed the child's stdout instance.

The change does not take the stdout instance, but uses a reference to read the current output from. This means the output of hickory is also available in tests.

Closes #2345

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2361 **Author:** [@justahero](https://github.com/justahero) **Created:** 8/15/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `sz-fix-hickory-stdout-output` --- ### 📝 Commits (1) - [`3c4c9b4`](https://github.com/hickory-dns/hickory-dns/commit/3c4c9b414dce5c86ee1ec7714f15b07a95b2c3e8) Fix stdout handling during hickory startup ### 📊 Changes **2 files changed** (+16 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/container.rs` (+7 -0) 📝 `conformance/packages/dns-test/src/resolver.rs` (+9 -6) </details> ### 📄 Description During the startup sequence of hickory a specific output is expected. This startup sequence consumed the child's `stdout` instance. The change does not take the stdout instance, but uses a reference to read the current output from. This means the output of hickory is also available in tests. Closes #2345 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>