[PR #2976] [MERGED] Change RecursorBuilder to take a list of IPs #3461

New issue

Closed

opened 2026-03-16 11:44:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2976
Author: @divergentdave
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/6/2025
Merged by: @divergentdave

Base: main ← Head: david/recursor-constructor-ips

📝 Commits (1)

1be3ea5 Change RecursorBuilder to take a list of IPs

📊 Changes

4 files changed (+25 additions, -123 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+7 -10)
📝 crates/recursor/src/recursor_dns_handle.rs (+3 -3)
📝 crates/server/src/store/recursor.rs (+4 -35)
📝 util/src/bin/recurse.rs (+11 -75)

📄 Description

This changes recursor constructors to take a slice of IP addresses instead of a NameServerConfigGroup. This reduces boilerplate and eliminates a source of misconfigurations. While this removes the ability to choose a different set of protocols or set a bind address in each NameServerConfig, these settings are not very useful when applied solely to the root zone. If there is need for such features in the future, they could be added as separate configuration, and applied to all name server connections made by the recursor.

Closes #2853.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2976 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/6/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/recursor-constructor-ips` --- ### 📝 Commits (1) - [`1be3ea5`](https://github.com/hickory-dns/hickory-dns/commit/1be3ea5c0a69b352eb37524f3d0ae40859ea8143) Change RecursorBuilder to take a list of IPs ### 📊 Changes **4 files changed** (+25 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+7 -10) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+3 -3) 📝 `crates/server/src/store/recursor.rs` (+4 -35) 📝 `util/src/bin/recurse.rs` (+11 -75) </details> ### 📄 Description This changes recursor constructors to take a slice of IP addresses instead of a `NameServerConfigGroup`. This reduces boilerplate and eliminates a source of misconfigurations. While this removes the ability to choose a different set of protocols or set a bind address in each `NameServerConfig`, these settings are not very useful when applied solely to the root zone. If there is need for such features in the future, they could be added as separate configuration, and applied to all name server connections made by the recursor. Closes #2853. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>