[PR #2354] [MERGED] Fix extra length prefix in unknown SVCB parameter #2976

New issue

Closed

opened 2026-03-16 11:18:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:18:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2354
Author: @divergentdave
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/15/2024
Merged by: @djc

Base: main ← Head: david/svcb-unknown-extra-length-prefix

📝 Commits (1)

d433e9b Fix extra length prefix in unknown SVCB parameter

📊 Changes

1 file changed (+26 additions, -4 deletions)

View changed files

📝 crates/proto/src/rr/rdata/svcb.rs (+26 -4)

📄 Description

This fixes one of the issues I listed in #2353, and adds a unit test for it.

The comment referencing appendix A of an earlier SVCB I-D is incorrect, as the appendix specifies the record's encoding in textual zone files, but this BinEncodable impl is for the RDATA wire format encoding (section 2.2).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2354 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/svcb-unknown-extra-length-prefix` --- ### 📝 Commits (1) - [`d433e9b`](https://github.com/hickory-dns/hickory-dns/commit/d433e9b0e58d1de45be31ab268126b61ab0eb6e6) Fix extra length prefix in unknown SVCB parameter ### 📊 Changes **1 file changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/svcb.rs` (+26 -4) </details> ### 📄 Description This fixes one of the issues I listed in #2353, and adds a unit test for it. The comment referencing appendix A of an earlier SVCB I-D is incorrect, as the appendix specifies the record's encoding in textual zone files, but this `BinEncodable` impl is for the RDATA wire format encoding (section 2.2). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>