[PR #2966] [MERGED] Inline all format argument, split out NoRecords type #3452

New issue

Closed

opened 2026-03-16 11:44:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2966
Author: @djc
Created: 5/5/2025
Status: ✅ Merged
Merged: 5/5/2025
Merged by: @djc

Base: main ← Head: nightly-clippy

📝 Commits (10+)

4912236 Inline format arguments (with clippy)
0df252b proto: drop empty line between docstring and item
45dd41c tests: replace iter().any() with contains()
c35a670 proto: fix Unicode support in zone file TTL parser
b0ed733 proto: remove unused ProofErrorKind variants
4fc7f48 client: remove separate error type
3cc7fb3 resolver: deduplicate NoRecordsFound construction
149ca6a resolver: simplify trusted state handling
4ae618b resolver: inline trivial method
0e6fac1 proto: split out NoRecords type

📊 Changes

35 files changed (+283 additions, -658 deletions)

View changed files

📝 bin/tests/integration/config_tests.rs (+1 -1)
📝 bin/tests/integration/named_metrics_tests.rs (+2 -4)
📝 bin/tests/integration/server_harness/mod.rs (+9 -7)
📝 crates/client/src/client/client.rs (+13 -17)
➖ crates/client/src/error.rs (+0 -180)
📝 crates/client/src/lib.rs (+0 -2)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+4 -4)
📝 crates/proto/src/dnssec/proof.rs (+1 -30)
📝 crates/proto/src/error.rs (+73 -67)
📝 crates/proto/src/lib.rs (+1 -1)
📝 crates/proto/src/rr/rdata/cert.rs (+2 -2)
📝 crates/proto/src/rr/rdata/tlsa.rs (+0 -1)
📝 crates/proto/src/serialize/txt/rdata_parsers/cert.rs (+3 -3)
📝 crates/proto/src/serialize/txt/zone.rs (+1 -1)
📝 crates/recursor/src/error.rs (+4 -18)
📝 crates/recursor/src/recursor.rs (+19 -21)
📝 crates/resolver/examples/custom_provider.rs (+1 -4)
📝 crates/resolver/src/caching_client.rs (+22 -116)
📝 crates/resolver/src/dns_lru.rs (+24 -52)
📝 crates/resolver/src/name_server/name_server_pool.rs (+3 -3)

...and 15 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2966 **Author:** [@djc](https://github.com/djc) **Created:** 5/5/2025 **Status:** ✅ Merged **Merged:** 5/5/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `nightly-clippy` --- ### 📝 Commits (10+) - [`4912236`](https://github.com/hickory-dns/hickory-dns/commit/49122366f3916c803a5aab0c8649ad0f47566d5d) Inline format arguments (with clippy) - [`0df252b`](https://github.com/hickory-dns/hickory-dns/commit/0df252b7d8e0147f9a342ffe2a43cf83ad5abd91) proto: drop empty line between docstring and item - [`45dd41c`](https://github.com/hickory-dns/hickory-dns/commit/45dd41c76f27615e19b79d7bfcf62b8dccd3d7d7) tests: replace iter().any() with contains() - [`c35a670`](https://github.com/hickory-dns/hickory-dns/commit/c35a67029feb2980cce31bda70937f559e8268f5) proto: fix Unicode support in zone file TTL parser - [`b0ed733`](https://github.com/hickory-dns/hickory-dns/commit/b0ed733681c8a8e7ade3993e43f2652c82e7f052) proto: remove unused ProofErrorKind variants - [`4fc7f48`](https://github.com/hickory-dns/hickory-dns/commit/4fc7f48905c3c43e16fc211fa02541fe4f42d9ab) client: remove separate error type - [`3cc7fb3`](https://github.com/hickory-dns/hickory-dns/commit/3cc7fb36d384d66aec6e7b56fe9f39e9640d94d8) resolver: deduplicate NoRecordsFound construction - [`149ca6a`](https://github.com/hickory-dns/hickory-dns/commit/149ca6ae782b95d7ed61430a3db229f7a1d36054) resolver: simplify trusted state handling - [`4ae618b`](https://github.com/hickory-dns/hickory-dns/commit/4ae618b51dee1bcd9dc6f1be26c521c80fd08d8c) resolver: inline trivial method - [`0e6fac1`](https://github.com/hickory-dns/hickory-dns/commit/0e6fac148140564a9bd7f4f6e9ad02bcfacd6b3f) proto: split out NoRecords type ### 📊 Changes **35 files changed** (+283 additions, -658 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/config_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_metrics_tests.rs` (+2 -4) 📝 `bin/tests/integration/server_harness/mod.rs` (+9 -7) 📝 `crates/client/src/client/client.rs` (+13 -17) ➖ `crates/client/src/error.rs` (+0 -180) 📝 `crates/client/src/lib.rs` (+0 -2) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+4 -4) 📝 `crates/proto/src/dnssec/proof.rs` (+1 -30) 📝 `crates/proto/src/error.rs` (+73 -67) 📝 `crates/proto/src/lib.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/cert.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/tlsa.rs` (+0 -1) 📝 `crates/proto/src/serialize/txt/rdata_parsers/cert.rs` (+3 -3) 📝 `crates/proto/src/serialize/txt/zone.rs` (+1 -1) 📝 `crates/recursor/src/error.rs` (+4 -18) 📝 `crates/recursor/src/recursor.rs` (+19 -21) 📝 `crates/resolver/examples/custom_provider.rs` (+1 -4) 📝 `crates/resolver/src/caching_client.rs` (+22 -116) 📝 `crates/resolver/src/dns_lru.rs` (+24 -52) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+3 -3) _...and 15 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>