[PR #2337] [MERGED] Suppress implicit features from optional dependencies #2966

New issue

Closed

opened 2026-03-16 11:17:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2337
Author: @djc
Created: 8/4/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @bluejekyll

Base: main ← Head: no-implicit-features

📝 Commits (6)

c2c04ac proto: suppress implicit features for optional dependencies
6deb9db client: suppress implicit features for optional dependencies
2eaf73c resolver: suppress implicit features for optional dependencies
f9890b2 server: fix compilation failures with dns-over-openssl enabled
088d004 server: suppress implicit features for optional dependencies
624bd78 recursor: suppress implicit features for optional dependencies

📊 Changes

22 files changed (+372 additions, -294 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 crates/client/Cargo.toml (+2 -3)
📝 crates/proto/Cargo.toml (+14 -15)
📝 crates/proto/src/error.rs (+29 -26)
📝 crates/proto/src/rr/dnssec/digest_type.rs (+26 -17)
📝 crates/proto/src/rr/dnssec/ec_public_key.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/key_format.rs (+28 -28)
📝 crates/proto/src/rr/dnssec/keypair.rs (+65 -62)
📝 crates/proto/src/rr/dnssec/mod.rs (+30 -18)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+12 -9)
📝 crates/proto/src/rr/dnssec/public_key.rs (+93 -66)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+11 -5)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+12 -6)
📝 crates/proto/src/rr/dnssec/rdata/key.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+24 -15)
📝 crates/proto/src/rr/dnssec/signer.rs (+2 -2)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+1 -1)
📝 crates/recursor/Cargo.toml (+1 -1)
📝 crates/resolver/Cargo.toml (+6 -6)
📝 crates/server/Cargo.toml (+6 -6)

...and 2 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2337 **Author:** [@djc](https://github.com/djc) **Created:** 8/4/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `no-implicit-features` --- ### 📝 Commits (6) - [`c2c04ac`](https://github.com/hickory-dns/hickory-dns/commit/c2c04accad59d88996c61967d62862dbcc2b9762) proto: suppress implicit features for optional dependencies - [`6deb9db`](https://github.com/hickory-dns/hickory-dns/commit/6deb9dbd79a5e869c35e1cd938889fdb9602011a) client: suppress implicit features for optional dependencies - [`2eaf73c`](https://github.com/hickory-dns/hickory-dns/commit/2eaf73c24117b65735487f8d2eebc1d9adcbc473) resolver: suppress implicit features for optional dependencies - [`f9890b2`](https://github.com/hickory-dns/hickory-dns/commit/f9890b209e9b4de53807eb1cbf80a9841dd0fe04) server: fix compilation failures with dns-over-openssl enabled - [`088d004`](https://github.com/hickory-dns/hickory-dns/commit/088d004d8aed8e032685a81b107316434b888c58) server: suppress implicit features for optional dependencies - [`624bd78`](https://github.com/hickory-dns/hickory-dns/commit/624bd78ba8eba2e8214b778a56f79e9ec7b67a7b) recursor: suppress implicit features for optional dependencies ### 📊 Changes **22 files changed** (+372 additions, -294 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `crates/client/Cargo.toml` (+2 -3) 📝 `crates/proto/Cargo.toml` (+14 -15) 📝 `crates/proto/src/error.rs` (+29 -26) 📝 `crates/proto/src/rr/dnssec/digest_type.rs` (+26 -17) 📝 `crates/proto/src/rr/dnssec/ec_public_key.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/key_format.rs` (+28 -28) 📝 `crates/proto/src/rr/dnssec/keypair.rs` (+65 -62) 📝 `crates/proto/src/rr/dnssec/mod.rs` (+30 -18) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+12 -9) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+93 -66) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+11 -5) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+12 -6) 📝 `crates/proto/src/rr/dnssec/rdata/key.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+24 -15) 📝 `crates/proto/src/rr/dnssec/signer.rs` (+2 -2) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+1 -1) 📝 `crates/recursor/Cargo.toml` (+1 -1) 📝 `crates/resolver/Cargo.toml` (+6 -6) 📝 `crates/server/Cargo.toml` (+6 -6) _...and 2 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>