[PR #2960] [MERGED] tests: tidy legacy config field comments #3446

New issue

Closed

opened 2026-03-16 11:44:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2960
Author: @cpu
Created: 4/30/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @djc

Base: main ← Head: cpu-toml-tidy

📝 Commits (1)

dd77e4b tests: tidy legacy config field comments

📊 Changes

4 files changed (+6 additions, -18 deletions)

View changed files

📝 tests/test-data/test_configs/all_supported_dnssec.toml (+0 -4)
📝 tests/test-data/test_configs/dnssec_with_update.toml (+1 -4)
📝 tests/test-data/test_configs/dnssec_with_update_2.toml (+1 -4)
📝 tests/test-data/test_configs/example.toml (+4 -6)

📄 Description

This branch removes commented out instances of some legacy config fields from test/example config files since they will error if uncommented.

The create_if_absent config field was removed back in 2017 to discourage this kind of adhoc key management.

The is_zone_signing_key and is_zone_update_auth config field were merged into a single purpose enum in 2024.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2960 **Author:** [@cpu](https://github.com/cpu) **Created:** 4/30/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `cpu-toml-tidy` --- ### 📝 Commits (1) - [`dd77e4b`](https://github.com/hickory-dns/hickory-dns/commit/dd77e4b0c57052a0919d278e18f71d2c8adca998) tests: tidy legacy config field comments ### 📊 Changes **4 files changed** (+6 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `tests/test-data/test_configs/all_supported_dnssec.toml` (+0 -4) 📝 `tests/test-data/test_configs/dnssec_with_update.toml` (+1 -4) 📝 `tests/test-data/test_configs/dnssec_with_update_2.toml` (+1 -4) 📝 `tests/test-data/test_configs/example.toml` (+4 -6) </details> ### 📄 Description This branch removes commented out instances of some legacy config fields from test/example config files since they will error if uncommented. The `create_if_absent` config field was [removed back in 2017](https://github.com/hickory-dns/hickory-dns/commit/f12fd8d23fc6fc5e52ff687221b8d966f1035bb3) to discourage this kind of adhoc key management. The `is_zone_signing_key` and `is_zone_update_auth` config field were [merged into a single `purpose` enum](https://github.com/hickory-dns/hickory-dns/commit/07e0183ffef0274d59ffb61f2da4619f2a63ef14) in 2024. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>