[PR #2336] [MERGED] only retry I/O errors over TCP #2960

New issue

Closed

opened 2026-03-16 11:17:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2336
Author: @lrouquette
Created: 8/2/2024
Status: ✅ Merged
Merged: 8/5/2024
Merged by: @bluejekyll

Base: main ← Head: retry-io-error-only

📝 Commits (4)

918659d restrict retry over tcp to i/o errors only, when enabled
bc97fae remove config, change match expr
e5651f9 fix test_datagram_fails_to_stream
8355c4a Merge branch 'main' into retry-io-error-only

📊 Changes

2 files changed (+131 additions, -2 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -1)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+130 -1)

📄 Description

Alternative to #2333.

NXDOMAIN / NoError are not retried over TCP. This is behind a feature flag (try_tcp_on_io_error_only) to preserve the current behavior by default.

Fixes: #2228

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2336 **Author:** [@lrouquette](https://github.com/lrouquette) **Created:** 8/2/2024 **Status:** ✅ Merged **Merged:** 8/5/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `retry-io-error-only` --- ### 📝 Commits (4) - [`918659d`](https://github.com/hickory-dns/hickory-dns/commit/918659d92ebb7bbf7f2c0bf4d3e279f7babf33b5) restrict retry over tcp to i/o errors only, when enabled - [`bc97fae`](https://github.com/hickory-dns/hickory-dns/commit/bc97fae854f930dbf961b5bbe3e3e1479a6ef125) remove config, change match expr - [`e5651f9`](https://github.com/hickory-dns/hickory-dns/commit/e5651f96b901945c8edcf505885b70d31f4131dd) fix test_datagram_fails_to_stream - [`8355c4a`](https://github.com/hickory-dns/hickory-dns/commit/8355c4a5e2042c0f5bef43b5a777a9f14b7a6b9f) Merge branch 'main' into retry-io-error-only ### 📊 Changes **2 files changed** (+131 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -1) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+130 -1) </details> ### 📄 Description Alternative to #2333. NXDOMAIN / NoError are not retried over TCP. This is behind a feature flag (`try_tcp_on_io_error_only`) to preserve the current behavior by default. Fixes: #2228 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>