[PR #2939] [MERGED] Remove extra query depth increments in verifier #3438

New issue

Closed

opened 2026-03-16 11:43:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:43:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2939
Author: @divergentdave
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/18/2025
Merged by: @divergentdave

Base: main ← Head: david/verifier-query-depth

📝 Commits (2)

aa90698 Remove extra query depth increments in verifier
5593f3f Add log message when exceeding request depth

📊 Changes

2 files changed (+5 additions, -20 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+0 -1)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+5 -19)

📄 Description

This fixes #2889 by removing some extra increments to DnssecDnsHandle's request depth. We now only increment it in the send() method, i.e. once per request, or twice per zone.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2939 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/18/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/verifier-query-depth` --- ### 📝 Commits (2) - [`aa90698`](https://github.com/hickory-dns/hickory-dns/commit/aa90698a07403de9b3cfeb23ebf070c729b99191) Remove extra query depth increments in verifier - [`5593f3f`](https://github.com/hickory-dns/hickory-dns/commit/5593f3fa5987d309e5f7464909070916972ba788) Add log message when exceeding request depth ### 📊 Changes **2 files changed** (+5 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+0 -1) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+5 -19) </details> ### 📄 Description This fixes #2889 by removing some extra increments to `DnssecDnsHandle`'s request depth. We now only increment it in the `send()` method, i.e. once per request, or twice per zone. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>