[PR #2304] [MERGED] server: empty the answer section when DNSSEC validation fails #2939

New issue

Closed

opened 2026-03-16 11:16:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2304
Author: @japaric
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @japaric

Base: main ← Head: ja-servfail-empty-answer-fix

📝 Commits (1)

1b2e267 server: empty the answer section when DNSSEC validation fails

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/adhoc.rs (+0 -1)
📝 crates/server/src/authority/catalog.rs (+3 -1)

📄 Description

and CD=0 (checking is enabled)

fixes the bug uncovered in PR #2302

~~this PR depends on #2302 so opening in draft state until that PR gets merged~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2304 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-servfail-empty-answer-fix` --- ### 📝 Commits (1) - [`1b2e267`](https://github.com/hickory-dns/hickory-dns/commit/1b2e267f813037959a212d0ac87e6f84c337b0b1) server: empty the answer section when DNSSEC validation fails ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/adhoc.rs` (+0 -1) 📝 `crates/server/src/authority/catalog.rs` (+3 -1) </details> ### 📄 Description and CD=0 (checking is enabled) fixes the bug uncovered in PR #2302 ~~this PR depends on #2302 so opening in draft state until that PR gets merged~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>