mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[PR #2928] [MERGED] Filter invalid DNS server addresses on windows OS #3431
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#3431
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/2928
Author: @watertreestar
Created: 4/13/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @djc
Base:
main← Head:windows-rfc3879📝 Commits (1)
613a462Filter invalid DNS server addresses on windows OS📊 Changes
1 file changed (+16 additions, -1 deletions)
View changed files
📝
crates/resolver/src/system_conf/windows.rs(+16 -1)📄 Description
Background
Windows systems set IPv6 site-local anycast DNS addresses with the fec0::/10 prefix by default when no other IPv6 DNS addresses are configured. However, these addresses have been deprecated since 2004 as per RFC 3879. Using these deprecated addresses may cause DNS resolution issues or unnecessary resolution attempts.
Due to this issue, when using the http module in Deno, requests become exceptionally slow, while using fetch does not exhibit this behavior.
Solution
This PR adds filtering logic for DNS server addresses in Windows system configuration, skipping IPv6 addresses that start with 0xfe and 0xc0 (i.e., addresses with the fec0::/10 prefix). This avoids using these deprecated DNS server addresses, improving resolution reliability.
Fixes #1968
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.