[PR #2293] [MERGED] DnssecDnsHandle: also update the RRSIG's proof #2928

New issue

Closed

opened 2026-03-16 11:15:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:15:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2293
Author: @japaric
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @japaric

Base: main ← Head: ja-update-rrsig-proof

📝 Commits (1)

a522a87 DnssecDnsHandle: also update the RRSIG's proof

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+0 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+11 -2)

📄 Description

fixes #2274

the reason queries with DO=1 were getting an AD=0 response was that DnssecDnsHandle was update the proof fields of all records in the response except for the RRSIG records, which should inherit the result of the DNSSEC validation.

~~this PR depends on PR #2287 so leaving it in draft state for now to prevent it being merged into the wrong branch~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2293 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-update-rrsig-proof` --- ### 📝 Commits (1) - [`a522a87`](https://github.com/hickory-dns/hickory-dns/commit/a522a87737e92decc5a639d70c55ca1c7d106caa) DnssecDnsHandle: also update the RRSIG's proof ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+0 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+11 -2) </details> ### 📄 Description fixes #2274 the reason queries with DO=1 were getting an AD=0 response was that `DnssecDnsHandle` was update the `proof` fields of all records in the response except for the RRSIG records, which should inherit the result of the DNSSEC validation. ~~this PR depends on PR #2287 so leaving it in draft state for now to prevent it being merged into the wrong branch~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>