[PR #2843] [MERGED] Use PEER, not test_peer(), in conformance tests #3360

New issue

Closed

opened 2026-03-16 11:39:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:39:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2843
Author: @divergentdave
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @divergentdave

Base: main ← Head: david/conformance-test-peer-cleanup

📝 Commits (1)

0acec1f Use PEER, not test_peer(), in conformance tests

📊 Changes

4 files changed (+10 additions, -8 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios/packet_loss.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs (+3 -3)
📝 conformance/packages/dns-test/src/implementation.rs (+3 -1)

📄 Description

The test_peer() function should not be used in conformance tests, because the intent is that the peer implementation should be selectable via environment variables from the different justfile recipes. It should only be used in e2e-tests, which is not given any environment variables. This PR cleans up some stray usages, and adds a note to the doc comment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2843 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/conformance-test-peer-cleanup` --- ### 📝 Commits (1) - [`0acec1f`](https://github.com/hickory-dns/hickory-dns/commit/0acec1f05edb2590c9b6d287ae9d9a1beb971fcd) Use PEER, not test_peer(), in conformance tests ### 📊 Changes **4 files changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios/packet_loss.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs` (+3 -3) 📝 `conformance/packages/dns-test/src/implementation.rs` (+3 -1) </details> ### 📄 Description The `test_peer()` function should not be used in conformance tests, because the intent is that the peer implementation should be selectable via environment variables from the different justfile recipes. It should only be used in `e2e-tests`, which is not given any environment variables. This PR cleans up some stray usages, and adds a note to the doc comment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>