[PR #2764] [MERGED] Replace certificate and key pairs with `Arc<dyn ResolvesServerCert>` #3301

New issue

Closed

opened 2026-03-16 11:36:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2764
Author: @msrd0
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @djc

Base: main ← Head: issue-2718-v2

📝 Commits (1)

a1cfc87 Replace certificate and key pairs with Arc<dyn ResolvesServerCert>

📊 Changes

8 files changed (+69 additions, -65 deletions)

View changed files

📝 Cargo.lock (+2 -2)
📝 Cargo.toml (+1 -1)
📝 bin/src/lib.rs (+11 -8)
📝 crates/proto/src/h3/h3_server.rs (+5 -7)
📝 crates/proto/src/quic/quic_server.rs (+5 -7)
📝 crates/proto/src/quic/tests.rs (+12 -3)
📝 crates/server/src/server/server_future.rs (+25 -35)
📝 tests/integration-tests/tests/integration/server_future_tests.rs (+8 -2)

📄 Description

I finally got around to implement this. As requested in #2718, I changed the method signatures to be incompatible with the old parameters. Since we needed the old functionality in the binary crate anyways and test code needed it too, I implemented a new CertificateAndKey struct that mimic's the internal behaviour of rustls, which is unfortunately not public.

Fixes #2718

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2764 **Author:** [@msrd0](https://github.com/msrd0) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `issue-2718-v2` --- ### 📝 Commits (1) - [`a1cfc87`](https://github.com/hickory-dns/hickory-dns/commit/a1cfc879ec00a75469eec09806ac883a6bce0174) Replace certificate and key pairs with `Arc<dyn ResolvesServerCert>` ### 📊 Changes **8 files changed** (+69 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -2) 📝 `Cargo.toml` (+1 -1) 📝 `bin/src/lib.rs` (+11 -8) 📝 `crates/proto/src/h3/h3_server.rs` (+5 -7) 📝 `crates/proto/src/quic/quic_server.rs` (+5 -7) 📝 `crates/proto/src/quic/tests.rs` (+12 -3) 📝 `crates/server/src/server/server_future.rs` (+25 -35) 📝 `tests/integration-tests/tests/integration/server_future_tests.rs` (+8 -2) </details> ### 📄 Description I finally got around to implement this. As requested in #2718, I changed the method signatures to be incompatible with the old parameters. Since we needed the old functionality in the binary crate anyways and test code needed it too, I implemented a new `CertificateAndKey` struct that mimic's the internal behaviour of rustls, which is unfortunately not public. Fixes #2718 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>