[PR #2025] [MERGED] Dont panic on nsec without dnssec #2764

New issue

Closed

opened 2026-03-16 11:06:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:06:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2025
Author: @bluejekyll
Created: 9/17/2023
Status: ✅ Merged
Merged: 9/20/2023
Merged by: @bluejekyll

Base: main ← Head: dont-panic-on-nsec-wihout-dnssec

📝 Commits (5)

2402d47 move Message tests into inner module
106d6da add awkward deserialization of message test
f8729ab make DNSClass parsing infallible
9e2cbfc track the RecordType on RData::Unknown instead of u16
b9b560a cleanup infallible DNSClass usage

📊 Changes

5 files changed (+162 additions, -116 deletions)

View changed files

📝 crates/proto/src/op/message.rs (+123 -105)
📝 crates/proto/src/op/query.rs (+2 -2)
📝 crates/proto/src/rr/dns_class.rs (+31 -3)
📝 crates/proto/src/rr/record_data.rs (+4 -4)
📝 crates/proto/src/rr/resource.rs (+2 -2)

📄 Description

Fixes: #2024

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2025 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 9/17/2023 **Status:** ✅ Merged **Merged:** 9/20/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `dont-panic-on-nsec-wihout-dnssec` --- ### 📝 Commits (5) - [`2402d47`](https://github.com/hickory-dns/hickory-dns/commit/2402d4709bfe37f82e6f992fbfaed18c273599bf) move Message tests into inner module - [`106d6da`](https://github.com/hickory-dns/hickory-dns/commit/106d6da8e2a0dd13f1ee36e0d917243308d17dab) add awkward deserialization of message test - [`f8729ab`](https://github.com/hickory-dns/hickory-dns/commit/f8729aba887f2dabfff888b2aaff90e5a5108dcf) make DNSClass parsing infallible - [`9e2cbfc`](https://github.com/hickory-dns/hickory-dns/commit/9e2cbfc846c56a8d2537a5577f1ea261d96a732f) track the RecordType on RData::Unknown instead of u16 - [`b9b560a`](https://github.com/hickory-dns/hickory-dns/commit/b9b560a5c8cfc49391a3d7c0af48513196c7e8ed) cleanup infallible DNSClass usage ### 📊 Changes **5 files changed** (+162 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/message.rs` (+123 -105) 📝 `crates/proto/src/op/query.rs` (+2 -2) 📝 `crates/proto/src/rr/dns_class.rs` (+31 -3) 📝 `crates/proto/src/rr/record_data.rs` (+4 -4) 📝 `crates/proto/src/rr/resource.rs` (+2 -2) </details> ### 📄 Description Fixes: #2024 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>