[PR #2666] [MERGED] Allow API consumer to use OS port assignment for UDP sockets #3217

New issue

Closed

opened 2026-03-16 11:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2666
Author: @marcus0x62
Created: 12/10/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @marcus0x62

Base: main ← Head: udp_os_port_assignment

📝 Commits (1)

12f1f91 Allow API consumer to use OS port assignment for UDP sockets

📊 Changes

5 files changed (+53 additions, -3 deletions)

View changed files

📝 crates/proto/src/tests/udp.rs (+1 -0)
📝 crates/proto/src/udp/udp_client_stream.rs (+22 -2)
📝 crates/proto/src/udp/udp_stream.rs (+17 -1)
📝 crates/resolver/src/config.rs (+12 -0)
📝 crates/resolver/src/name_server/connection_provider.rs (+1 -0)

📄 Description

@djc this is #2565 with the changes I recommended. I kept the boolean flag on the with_os_port_selection builder for UdpClientStreamBuilder - it seems to be the easiest way to bridge the configuration between the connection provider and the client stream builder.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2666 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `udp_os_port_assignment` --- ### 📝 Commits (1) - [`12f1f91`](https://github.com/hickory-dns/hickory-dns/commit/12f1f91993ccf6e7a744468a1edfc8d45062aa8a) Allow API consumer to use OS port assignment for UDP sockets ### 📊 Changes **5 files changed** (+53 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/tests/udp.rs` (+1 -0) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+22 -2) 📝 `crates/proto/src/udp/udp_stream.rs` (+17 -1) 📝 `crates/resolver/src/config.rs` (+12 -0) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+1 -0) </details> ### 📄 Description @djc this is #2565 with the changes I recommended. I kept the boolean flag on the with_os_port_selection builder for UdpClientStreamBuilder - it seems to be the easiest way to bridge the configuration between the connection provider and the client stream builder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>