[PR #1879] [MERGED] Move client code used by server code down into proto #2666

New issue

Closed

opened 2026-03-16 11:01:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:01:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1879
Author: @djc
Created: 1/10/2023
Status: ✅ Merged
Merged: 2/6/2023
Merged by: @bluejekyll

Base: main ← Head: client-to-proto

📝 Commits (4)

05dfa8b Move client code used by server code down into proto
20648d7 add docsrs feature doc for text-parsing
9a41974 fix formatting for inline variables
a35f331 update Tokio soundness warning: RUSTSEC-2023-0005

📊 Changes

165 files changed (+950 additions, -1214 deletions)

View changed files

📝 Cargo.lock (+2 -3)
📝 bin/src/trust-dns.rs (+2 -2)
📝 bin/tests/named_https_tests.rs (+2 -3)
📝 bin/tests/named_quic_tests.rs (+1 -2)
📝 bin/tests/named_rustls_tests.rs (+2 -3)
📝 bin/tests/named_test_rsa_dnssec.rs (+2 -2)
📝 bin/tests/server_harness/mod.rs (+8 -10)
📝 crates/client/Cargo.toml (+1 -1)
📝 crates/client/src/client/async_client.rs (+2 -7)
📝 crates/client/src/client/client.rs (+4 -5)
📝 crates/client/src/client/client_connection.rs (+3 -4)
📝 crates/client/src/error/client_error.rs (+1 -2)
➖ crates/client/src/error/dnssec_error.rs (+0 -219)
➖ crates/client/src/error/lexer_error.rs (+0 -101)
📝 crates/client/src/error/mod.rs (+0 -15)
📝 crates/client/src/lib.rs (+1 -1)
📝 crates/client/src/op/mod.rs (+1 -6)
➖ crates/client/src/rr/dnssec/mod.rs (+0 -87)
📝 crates/client/src/rr/mod.rs (+0 -7)
📝 crates/client/src/serialize/mod.rs (+1 -1)

...and 80 more files

📄 Description

All the low-level stuff in the client code was quite generic (and in fact used by the server).

As a future improvement, we might move all the networking stuff out of -proto into a trust-dns-net crate maybe? It would be nice if trust-dns-proto was sans-io.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1879 **Author:** [@djc](https://github.com/djc) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 2/6/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `client-to-proto` --- ### 📝 Commits (4) - [`05dfa8b`](https://github.com/hickory-dns/hickory-dns/commit/05dfa8b9b1d5cb4a1dc23501cd465e26c2e751bf) Move client code used by server code down into proto - [`20648d7`](https://github.com/hickory-dns/hickory-dns/commit/20648d72afc84613739166081be6401894375dbc) add docsrs feature doc for text-parsing - [`9a41974`](https://github.com/hickory-dns/hickory-dns/commit/9a4197484e4f8ec18cfad25738c183905ef05921) fix formatting for inline variables - [`a35f331`](https://github.com/hickory-dns/hickory-dns/commit/a35f33156368b7c7c4dec96796e96570cbb5e02c) update Tokio soundness warning: RUSTSEC-2023-0005 ### 📊 Changes **165 files changed** (+950 additions, -1214 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -3) 📝 `bin/src/trust-dns.rs` (+2 -2) 📝 `bin/tests/named_https_tests.rs` (+2 -3) 📝 `bin/tests/named_quic_tests.rs` (+1 -2) 📝 `bin/tests/named_rustls_tests.rs` (+2 -3) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+2 -2) 📝 `bin/tests/server_harness/mod.rs` (+8 -10) 📝 `crates/client/Cargo.toml` (+1 -1) 📝 `crates/client/src/client/async_client.rs` (+2 -7) 📝 `crates/client/src/client/client.rs` (+4 -5) 📝 `crates/client/src/client/client_connection.rs` (+3 -4) 📝 `crates/client/src/error/client_error.rs` (+1 -2) ➖ `crates/client/src/error/dnssec_error.rs` (+0 -219) ➖ `crates/client/src/error/lexer_error.rs` (+0 -101) 📝 `crates/client/src/error/mod.rs` (+0 -15) 📝 `crates/client/src/lib.rs` (+1 -1) 📝 `crates/client/src/op/mod.rs` (+1 -6) ➖ `crates/client/src/rr/dnssec/mod.rs` (+0 -87) 📝 `crates/client/src/rr/mod.rs` (+0 -7) 📝 `crates/client/src/serialize/mod.rs` (+1 -1) _...and 80 more files_ </details> ### 📄 Description All the low-level stuff in the client code was quite generic (and in fact used by the server). As a future improvement, we might move all the networking stuff out of -proto into a trust-dns-net crate maybe? It would be nice if trust-dns-proto was [sans-io](https://sans-io.readthedocs.io/). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>