[PR #2650] [MERGED] Move LookupFuture to resolver module #3202

New issue

Closed

opened 2026-03-16 11:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2650
Author: @divergentdave
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @djc

Base: main ← Head: david/move-lookup-future

📝 Commits (1)

d5a48a4 Move LookupFuture to resolver module

📊 Changes

5 files changed (+290 additions, -294 deletions)

View changed files

📝 crates/async-std-resolver/src/tests.rs (+1 -1)
📝 crates/resolver/src/lib.rs (+1 -0)
📝 crates/resolver/src/lookup.rs (+7 -282)
📝 crates/resolver/src/resolver.rs (+279 -6)
📝 tests/integration-tests/tests/integration/lookup_tests.rs (+2 -5)

📄 Description

This moves LookupFuture to the resolver module, next to Resolver, which produces it. This future doesn't have much in common with the rest of the lookup module, other than the name prefix, as the rest of the structs there are data-storing structs and filtering iterators.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2650 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/move-lookup-future` --- ### 📝 Commits (1) - [`d5a48a4`](https://github.com/hickory-dns/hickory-dns/commit/d5a48a44334711b6afa6c7b9161a6232955ad1b6) Move LookupFuture to resolver module ### 📊 Changes **5 files changed** (+290 additions, -294 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/src/tests.rs` (+1 -1) 📝 `crates/resolver/src/lib.rs` (+1 -0) 📝 `crates/resolver/src/lookup.rs` (+7 -282) 📝 `crates/resolver/src/resolver.rs` (+279 -6) 📝 `tests/integration-tests/tests/integration/lookup_tests.rs` (+2 -5) </details> ### 📄 Description This moves `LookupFuture` to the `resolver` module, next to `Resolver`, which produces it. This future doesn't have much in common with the rest of the `lookup` module, other than the name prefix, as the rest of the structs there are data-storing structs and filtering iterators. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>