[PR #1850] [MERGED] Fix $TTL not taken into account with wildcard from zonefile. #2650

New issue

Closed

opened 2026-03-16 11:00:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:00:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1850
Author: @darnuria
Created: 12/4/2022
Status: ✅ Merged
Merged: 12/4/2022
Merged by: @bluejekyll

Base: main ← Head: fix/1849

📝 Commits (3)

87a1e60 WIP: Fix $TTL not taken into account with wildcard from zonefile.
e70945d WIP: Getting closer to the problem.
9fcb854 Fix #1849 TTL was not updated in wildcard codepath.

📊 Changes

3 files changed (+47 additions, -3 deletions)

View changed files

📝 crates/server/src/store/in_memory/authority.rs (+3 -2)
📝 crates/server/tests/store_file_tests.rs (+39 -1)
➕ tests/test-data/named_test_configs/default/test.local.zone (+5 -0)

📄 Description

Investigation arround https://github.com/bluejekyll/trust-dns/issues/1849

I openned the PR to get feedback, it's not done yet. :)

Fixes: #1849

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1850 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 12/4/2022 **Status:** ✅ Merged **Merged:** 12/4/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix/1849` --- ### 📝 Commits (3) - [`87a1e60`](https://github.com/hickory-dns/hickory-dns/commit/87a1e60a2b66a96a5f075bce5ede1261a314e5f8) WIP: Fix $TTL not taken into account with wildcard from zonefile. - [`e70945d`](https://github.com/hickory-dns/hickory-dns/commit/e70945d124ee2f252931195870afb53c2206f016) WIP: Getting closer to the problem. - [`9fcb854`](https://github.com/hickory-dns/hickory-dns/commit/9fcb854e366d44587e689c89fc4a7ea69dfb1092) Fix #1849 TTL was not updated in wildcard codepath. ### 📊 Changes **3 files changed** (+47 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/authority.rs` (+3 -2) 📝 `crates/server/tests/store_file_tests.rs` (+39 -1) ➕ `tests/test-data/named_test_configs/default/test.local.zone` (+5 -0) </details> ### 📄 Description Investigation arround https://github.com/bluejekyll/trust-dns/issues/1849 I openned the PR to get feedback, it's not done yet. :) ---- Fixes: #1849 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>