[PR #2567] [MERGED] resolver NameServerPool tweaks #3145

New issue

Closed

opened 2026-03-16 11:27:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:27:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2567
Author: @djc
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/17/2024
Merged by: @djc

Base: main ← Head: pool-tweaks

📝 Commits (5)

1e85f2d resolver: clean up imports
db78980 resolver: move test-only impl into tests module
cf73879 resolver: move GenericNameServerPool above NameServerPool definition
c125395 resolver: collect directly into Arc<[T]>
13131bb resolver: tweak formatting

📊 Changes

1 file changed (+30 additions, -43 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server_pool.rs (+30 -43)

📄 Description

Follow-up from reviewing #2557.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2567 **Author:** [@djc](https://github.com/djc) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 11/17/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `pool-tweaks` --- ### 📝 Commits (5) - [`1e85f2d`](https://github.com/hickory-dns/hickory-dns/commit/1e85f2db619c850c6740f8fb1181cc943ca5a317) resolver: clean up imports - [`db78980`](https://github.com/hickory-dns/hickory-dns/commit/db789806293282b21b4a5664a6d0e9f7e6c422ad) resolver: move test-only impl into tests module - [`cf73879`](https://github.com/hickory-dns/hickory-dns/commit/cf73879e312f4ad412cbfaaac278784b895ef142) resolver: move GenericNameServerPool above NameServerPool definition - [`c125395`](https://github.com/hickory-dns/hickory-dns/commit/c12539599eb6a8f850bc629f1e479a8cf4bc0eb0) resolver: collect directly into Arc<[T]> - [`13131bb`](https://github.com/hickory-dns/hickory-dns/commit/13131bbe2fb3ec155f500d4e6f935ec424c77176) resolver: tweak formatting ### 📊 Changes **1 file changed** (+30 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+30 -43) </details> ### 📄 Description Follow-up from reviewing #2557. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>