[PR #1749] [MERGED] Make maximum request depth configurable #2567

Closed
opened 2026-03-16 10:12:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1749
Author: @wiktor-k
Created: 8/1/2022
Status: Merged
Merged: 8/1/2022
Merged by: @djc

Base: mainHead: make-request-depth-configurable


📝 Commits (1)

  • 5ef1070 Make maximum request depth configurable

📊 Changes

2 files changed (+17 additions, -3 deletions)

View changed files

📝 crates/proto/src/xfer/dns_request.rs (+15 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+2 -2)

📄 Description

This PR addresses the comment left in the source code allowing clients to adjust the request depth. This is especially important in DNSSEC queries for which the default request depth may not be enough. This PR depends on other merged PRs like #1742.

Fixes #1735.

Thank you for your time! 👋


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1749 **Author:** [@wiktor-k](https://github.com/wiktor-k) **Created:** 8/1/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `make-request-depth-configurable` --- ### 📝 Commits (1) - [`5ef1070`](https://github.com/hickory-dns/hickory-dns/commit/5ef10706fdb3e5b4afa210a4b2b45596cfb364e3) Make maximum request depth configurable ### 📊 Changes **2 files changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/dns_request.rs` (+15 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+2 -2) </details> ### 📄 Description This PR addresses the comment left in the source code allowing clients to adjust the request depth. This is especially important in DNSSEC queries for which the default request depth may not be enough. This PR depends on other merged PRs like #1742. Fixes #1735. Thank you for your time! :wave: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 10:12:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2567
No description provided.